openstack/python-openstackclient
Code Issues Proposed changes

Merge "Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests"

Browse Source
This commit is contained in:
Jenkins 2016-02-08 16:21:00 +00:00 committed by Gerrit Code Review
commit 624c39ab1b
3 changed files with 36 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/tests/compute/v2/test_security_group.py
View File

@ -87,7 +87,9 @@ class TestSecurityGroupCreate(TestSecurityGroup):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)
@ -110,7 +112,9 @@ class TestSecurityGroupCreate(TestSecurityGroup):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)

20
openstackclient/tests/compute/v2/test_security_group_rule.py
View File

@ -149,7 +149,9 @@ class TestSecurityGroupRuleCreate(TestSecurityGroupRule):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)
@ -193,7 +195,9 @@ class TestSecurityGroupRuleCreate(TestSecurityGroupRule):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)
@ -241,7 +245,9 @@ class TestSecurityGroupRuleCreate(TestSecurityGroupRule):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)
@ -284,7 +290,9 @@ class TestSecurityGroupRuleCreate(TestSecurityGroupRule):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)
@ -330,7 +338,9 @@ class TestSecurityGroupRuleCreate(TestSecurityGroupRule):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# SecurityGroupManager.create(name, description) # SecurityGroupManager.create(name, description)

20
openstackclient/tests/compute/v2/test_server.py
View File

@ -163,7 +163,9 @@ class TestServerCreate(TestServer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# Set expected values # Set expected values
@ -241,7 +243,9 @@ class TestServerCreate(TestServer):
self.app.client_manager.network.find_network = find_network self.app.client_manager.network.find_network = find_network
self.app.client_manager.network.find_port = find_port self.app.client_manager.network.find_port = find_port
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# Set expected values # Set expected values
@ -299,7 +303,9 @@ class TestServerCreate(TestServer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# Ensure the userdata file is opened # Ensure the userdata file is opened
@ -551,7 +557,9 @@ class TestServerImageCreate(TestServer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# ServerManager.create_image(server, image_name, metadata=) # ServerManager.create_image(server, image_name, metadata=)
@ -574,7 +582,9 @@ class TestServerImageCreate(TestServer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# DisplayCommandBase.take_action() returns two tuples # In base command class ShowOne in cliff, abstractmethod take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
# ServerManager.create_image(server, image_name, metadata=) # ServerManager.create_image(server, image_name, metadata=)