From 885b1149c309667c6e4c3092b67fef3c01a15178 Mon Sep 17 00:00:00 2001 From: Rodolfo Alonso Hernandez Date: Tue, 10 Oct 2017 14:04:40 +0100 Subject: [PATCH] Avoid default mutable values in arguments Mutable values shouldn't be used as default values in function arguments [1]. [1] http://docs.python-guide.org/en/latest/writing/gotchas/ Change-Id: I3c7f915f0409c77f4c430467365eb1bcfd7757b3 --- openstackclient/network/sdk_utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openstackclient/network/sdk_utils.py b/openstackclient/network/sdk_utils.py index 04f168bea3..9f0856175d 100644 --- a/openstackclient/network/sdk_utils.py +++ b/openstackclient/network/sdk_utils.py @@ -16,7 +16,7 @@ import six def get_osc_show_columns_for_sdk_resource( sdk_resource, osc_column_map, - invisible_columns=[] + invisible_columns=None ): """Get and filter the display and attribute columns for an SDK resource. @@ -40,6 +40,7 @@ def get_osc_show_columns_for_sdk_resource( # Build the OSC column names to display for the SDK resource. attr_map = {} display_columns = list(resource_dict.keys()) + invisible_columns = [] if invisible_columns is None else invisible_columns for col_name in invisible_columns: if col_name in display_columns: display_columns.remove(col_name)