openstack/python-openstackclient
Code Issues Proposed changes

Cleanup after install

Browse Source 
Tox tests are run on developer machines and on long lived slaves. We
should not leave lots of directories like
/tmp/python-openstackclient-tox_install-sdnltRu lying around.

Instead delete the temporary directory after our run.

Remove also an obsolete comment.

Change-Id: I939eae82dba3287fd4e4086128ebf4609a0e0770
This commit is contained in:
Andreas Jaeger 2016-08-28 08:42:07 +02:00
parent a08b62523f
commit 9962403d3c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/tox_install.sh
View File

@ -16,6 +16,7 @@ shift
install_cmd="pip install" install_cmd="pip install"
mydir=$(mktemp -dt "$CLIENT_NAME-tox_install-XXXXXXX") mydir=$(mktemp -dt "$CLIENT_NAME-tox_install-XXXXXXX")
trap "rm -rf $mydir" EXIT
localfile=$mydir/upper-constraints.txt localfile=$mydir/upper-constraints.txt
if [[ $CONSTRAINTS_FILE != http* ]]; then if [[ $CONSTRAINTS_FILE != http* ]]; then
CONSTRAINTS_FILE=file://$CONSTRAINTS_FILE CONSTRAINTS_FILE=file://$CONSTRAINTS_FILE
@ -27,7 +28,6 @@ if [ $requirements_installed -eq 0 ]; then
echo "ALREADY INSTALLED" > /tmp/tox_install.txt echo "ALREADY INSTALLED" > /tmp/tox_install.txt
echo "Requirements already installed; using existing package" echo "Requirements already installed; using existing package"
elif [ -x "$ZUUL_CLONER" ]; then elif [ -x "$ZUUL_CLONER" ]; then
# If this is called in a periodic job, these will not be set
echo "ZUUL CLONER" > /tmp/tox_install.txt echo "ZUUL CLONER" > /tmp/tox_install.txt
pushd $mydir pushd $mydir
$ZUUL_CLONER --cache-dir \ $ZUUL_CLONER --cache-dir \