openstack/python-openstackclient
Code Issues Proposed changes

Merge "image/v2: support multiple property filters"

Browse Source
This commit is contained in:
Zuul 2018-11-08 05:40:17 +00:00 committed by Gerrit Code Review
commit 9b1e5f052e
2 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
openstackclient/image/v2/image.py
View File

@ -515,7 +515,8 @@ class ListImage(command.Lister):
'--property', '--property',
metavar='<key=value>', metavar='<key=value>',
action=parseractions.KeyValueAction, action=parseractions.KeyValueAction,
help=_('Filter output based on property'), help=_('Filter output based on property '
'(repeat option to filter on multiple properties)'),
) )
parser.add_argument( parser.add_argument(
'--name', '--name',
@ -643,14 +644,13 @@ class ListImage(command.Lister):
marker = page[-1]['id'] marker = page[-1]['id']
if parsed_args.property: if parsed_args.property:
# NOTE(dtroyer): coerce to a list to subscript it in py3 for attr, value in parsed_args.property.items():
attr, value = list(parsed_args.property.items())[0] api_utils.simple_filter(
api_utils.simple_filter( data,
data, attr=attr,
attr=attr, value=value,
value=value, property_field='properties',
property_field='properties', )
)
data = utils.sort_items(data, parsed_args.sort, str) data = utils.sort_items(data, parsed_args.sort, str)

6
releasenotes/notes/image-list-filter-multiple-properties-03c51d43131ee3b6.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- |
The ``image list`` command now properly filters images on multiple
``--property`` options.
[Bug `2004290 <https://storyboard.openstack.org/#!/story/2004290>`_]