openstack/python-openstackclient
Code Issues Proposed changes

Rename review.openstack.org to review.opendev.org

Browse Source 
There are many references to review.openstack.org, and while the
redirect should work, we can also go ahead and fix them.

Change-Id: I82e3797dd4c05e4944f40c950b4fafe9a5334cbf
This commit is contained in:
melissaml 2019-05-12 04:40:55 +08:00
parent 1bc44fcdc6
commit aabc67f3a2
5 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
doc/source/cli/backwards-incompatible.rst
View File

@ -46,7 +46,7 @@ Release 3.12
* As of: 3.12.0
* Removed in: n/a
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1657956
* Commit: https://review.openstack.org/#/c/423081/
* Commit: https://review.opendev.org/#/c/423081/
Release 3.10
------------
@ -55,7 +55,7 @@ Release 3.10
with Nova-network clouds.
* As of: 3.10
* Commit: https://review.openstack.org/460679
* Commit: https://review.opendev.org/460679
2. The positional argument ``<snapshot-name>`` of the ``volume snapshot create``
command is no longer optional.
@ -67,7 +67,7 @@ Release 3.10
* As of: 3.10
* Bug: 1659894
* Commit: https://review.openstack.org/440497
* Commit: https://review.opendev.org/440497
Release 3.0
-----------
@ -81,7 +81,7 @@ Release 3.0
* As of: 3.0
* Removed in: n/a
* Bug: n/a
* Commit: https://review.openstack.org/332938
* Commit: https://review.opendev.org/332938
Releases Before 3.0
@ -95,7 +95,7 @@ Releases Before 3.0
* As of: 1.0.2
* Removed in: TBD
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1406654
* Commit: https://review.openstack.org/#/c/147379/
* Commit: https://review.opendev.org/#/c/147379/
2. <type> should not be optional for command `openstack service create`
@ -107,7 +107,7 @@ Releases Before 3.0
* As of: 1.0.2
* Removed in: TBD
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1404073
* Commit: https://review.openstack.org/#/c/143242/
* Commit: https://review.opendev.org/#/c/143242/
3. Command `openstack security group rule delete` now requires rule id
@ -119,7 +119,7 @@ Releases Before 3.0
* As of: 1.2.1
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1450872
* Commit: https://review.openstack.org/#/c/179446/
* Commit: https://review.opendev.org/#/c/179446/
4. Command `openstack image create` does not update already existing image
@ -133,7 +133,7 @@ Releases Before 3.0
* As of: 1.5.0
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1461817
* Commit: https://review.openstack.org/#/c/194654/
* Commit: https://review.opendev.org/#/c/194654/
5. Command `openstack network list --dhcp` has been removed
@ -147,7 +147,7 @@ Releases Before 3.0
* As of: 1.6.0
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/472613
* Commit: https://review.openstack.org/#/c/194654/
* Commit: https://review.opendev.org/#/c/194654/
6. Plugin interface change for default API versions
@ -162,7 +162,7 @@ Releases Before 3.0
* As of: 1.2.1
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1453229
* Commit: https://review.openstack.org/#/c/181514/
* Commit: https://review.opendev.org/#/c/181514/
7. `image set` commands will no longer return the modified resource
@ -186,7 +186,7 @@ Releases Before 3.0
* As of 1.9.0
* Removed in: NA
* Bug: https://launchpad.net/bugs/1506841
* Commit: https://review.openstack.org/#/c/236736/
* Commit: https://review.opendev.org/#/c/236736/
9. `flavor set/unset` commands will no longer return the modified resource
@ -198,7 +198,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.openstack.org/#/c/280663/
* Commit: https://review.opendev.org/#/c/280663/
10. `security group set` commands will no longer return the modified resource
@ -210,7 +210,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.openstack.org/#/c/281087/
* Commit: https://review.opendev.org/#/c/281087/
11. `compute agent set` commands will no longer return the modified resource
@ -222,7 +222,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.openstack.org/#/c/281088/
* Commit: https://review.opendev.org/#/c/281088/
12. `<version> <url> <md5hash>` should be optional for command `openstack
compute agent set`
@ -235,7 +235,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: NA
* Commit: https://review.openstack.org/#/c/328819/
* Commit: https://review.opendev.org/#/c/328819/
13. `aggregate set` commands will no longer return the modified resource
@ -247,7 +247,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1546065
* Commit: https://review.openstack.org/#/c/281089/
* Commit: https://review.opendev.org/#/c/281089/
14. Output of `ip floating list` command has changed.
@ -291,7 +291,7 @@ Releases Before 3.0
* As of: NA
* Removed in: NA
* Bug: https://bugs.launchpad.net/python-openstackclient/+bug/1519502
* Commit: https://review.openstack.org/#/c/277720/
* Commit: https://review.opendev.org/#/c/277720/
For Developers
==============
@ -302,4 +302,4 @@ update this file.
To review all changes that are affected, use the following query:
https://review.openstack.org/#/q/project:openstack/python-openstackclient+AND+message:BackwardsIncompatibleImpact,n,z
https://review.opendev.org/#/q/project:openstack/python-openstackclient+AND+message:BackwardsIncompatibleImpact,n,z

2
openstackclient/compute/v2/flavor.py
View File

@ -432,7 +432,7 @@ class ShowFlavor(command.ShowOne):
projects = [utils.get_field(access, 'tenant_id')
for access in flavor_access]
# TODO(Huanxuan Ao): This format case can be removed after
# patch https://review.openstack.org/#/c/330223/ merged.
# patch https://review.opendev.org/#/c/330223/ merged.
access_projects = utils.format_list(projects)
except Exception as e:
msg = _("Failed to get access projects list "

2
openstackclient/tests/functional/compute/v2/test_server.py
View File

@ -407,7 +407,7 @@ class ServerTests(common.ComputeTestCase):
cmd_output['status'],
)
# NOTE(dtroyer): Prior to https://review.openstack.org/#/c/407111
# NOTE(dtroyer): Prior to https://review.opendev.org/#/c/407111
# --block-device-mapping was ignored if --volume
# present on the command line. Now we should see the
# attachment.

2
openstackclient/tests/unit/api/test_object_store_v1.py
View File

@ -184,7 +184,7 @@ class TestObject(TestObjectAPIv1):
}
# TODO(dtroyer): When requests_mock gains the ability to
# match against request.body add this check
# https://review.openstack.org/127316
# https://review.opendev.org/127316
self.requests_mock.register_uri(
'PUT',
FAKE_URL + '/qaz/counter.txt',

2
openstackclient/volume/v2/volume_type.py
View File

@ -501,7 +501,7 @@ class ShowVolumeType(command.ShowOne):
project_ids = [utils.get_field(item, 'project_id')
for item in volume_type_access]
# TODO(Rui Chen): This format list case can be removed after
# patch https://review.openstack.org/#/c/330223/ merged.
# patch https://review.opendev.org/#/c/330223/ merged.
access_project_ids = utils.format_list(project_ids)
except Exception as e:
msg = _('Failed to get access project list for volume type '