openstack/python-openstackclient
Code Issues Proposed changes

Fix wrong return value in TestDeleteFloatingIPNetwork

Browse Source 
delete_ip() should return None, not the fake floating IP.

Change-Id: I1476189a09a94c76c90f9a3986e3ae57dc66d796
This commit is contained in:
Tang Chen 2016-02-23 20:19:14 +08:00
parent 02e5b6f41d
commit ab40add0c6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/tests/network/v2/test_floating_ip.py
View File

@ -37,7 +37,7 @@ class TestDeleteFloatingIPNetwork(TestFloatingIPNetwork):
def setUp(self): def setUp(self):
super(TestDeleteFloatingIPNetwork, self).setUp() super(TestDeleteFloatingIPNetwork, self).setUp()
self.network.delete_ip = mock.Mock(return_value=self.floating_ip) self.network.delete_ip = mock.Mock(return_value=None)
self.network.find_ip = mock.Mock(return_value=self.floating_ip) self.network.find_ip = mock.Mock(return_value=self.floating_ip)
# Get the command object to test # Get the command object to test