openstack/python-openstackclient
Code Issues Proposed changes

TestServerGeneral: Add test for _format_servers_list_networks()

Browse Source 
The items in a dict are in random order. So if a server is in two networks,
there may be two results after formatted.

Change-Id: I2e15d202639e3fff427935f46650a405b0e51bcc
Implements: blueprint osc-unit-test-framework-improvement
This commit is contained in:
Tang Chen 2015-12-08 19:10:46 +08:00
parent b220f4b667
commit b4660fec7d
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openstackclient/tests/compute/v2/test_server.py
View File

@ -1136,3 +1136,27 @@ class TestServerGeneral(testtools.TestCase):
server._format_servers_list_power_state(0x07)) server._format_servers_list_power_state(0x07))
self.assertEqual("N/A", self.assertEqual("N/A",
server._format_servers_list_power_state(0x08)) server._format_servers_list_power_state(0x08))
def test_format_servers_list_networks(self):
# Setup network info to test.
networks = {
u'public': [u'10.20.30.40', u'2001:db8::f'],
u'private': [u'2001:db8::f', u'10.20.30.40'],
}
# Prepare expected data.
# Since networks is a dict, whose items are in random order, there
# could be two results after formatted.
data_1 = (u'private=2001:db8::f, 10.20.30.40; '
u'public=10.20.30.40, 2001:db8::f')
data_2 = (u'public=10.20.30.40, 2001:db8::f; '
u'private=2001:db8::f, 10.20.30.40')
# Call _format_servers_list_networks().
networks_format = server._format_servers_list_networks(networks)
msg = ('Network string is not formatted correctly.\n'
'reference = %s or %s\n'
'actual = %s\n' %
(data_1, data_2, networks_format))
self.assertIn(networks_format, (data_1, data_2), msg)