openstack/python-openstackclient
Code Issues Proposed changes

Adopt sdk_fakes for compute.test_console

Browse Source 
Change-Id: I6181009a8b2ae7e632214364527ccc6fdd03fff9
This commit is contained in:
Artem Goncharov 2023-06-07 14:41:21 +02:00 committed by Stephen Finucane
parent 329b351cb8
commit d175dea6bc
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openstackclient/tests/unit/compute/v2/test_console.py
View File

@ -15,6 +15,9 @@
from unittest import mock from unittest import mock
from openstack.compute.v2 import server as _server
from openstack.test import fakes as sdk_fakes
from openstackclient.compute.v2 import console from openstackclient.compute.v2 import console
from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
from openstackclient.tests.unit import utils from openstackclient.tests.unit import utils
@ -24,7 +27,7 @@ class TestConsoleLog(compute_fakes.TestComputev2):
def setUp(self): def setUp(self):
super().setUp() super().setUp()
self._server = compute_fakes.create_one_sdk_server() self._server = sdk_fakes.generate_fake_resource(_server.Server)
self.compute_sdk_client.find_server.return_value = self._server self.compute_sdk_client.find_server.return_value = self._server
self.cmd = console.ShowConsoleLog(self.app, None) self.cmd = console.ShowConsoleLog(self.app, None)
@ -76,11 +79,12 @@ class TestConsoleLog(compute_fakes.TestComputev2):
class TestConsoleUrlShow(compute_fakes.TestComputev2): class TestConsoleUrlShow(compute_fakes.TestComputev2):
_server = compute_fakes.create_one_sdk_server()
def setUp(self): def setUp(self):
super().setUp() super().setUp()
self._server = sdk_fakes.generate_fake_resource(_server.Server)
self.compute_sdk_client.find_server.return_value = self._server self.compute_sdk_client.find_server.return_value = self._server
fake_console_data = { fake_console_data = {
'url': 'http://localhost', 'url': 'http://localhost',
'protocol': 'fake_protocol', 'protocol': 'fake_protocol',