osc-lib: exceptions

Use osc-lib directly for exceptions.

Leave openstackclient.common.exceptions for deprecation period.

Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828

doc/source/plugins.rst

@@ -151,9 +151,11 @@ the plugin commands:
 
 .. code-block:: python
 
+    # osc-lib interfaces available to plugins:
+    from osc_lib import exceptions
+
     # OSC common interfaces available to plugins:
     from openstackclient.common import command
-    from openstackclient.common import exceptions
     from openstackclient.common import parseractions
     from openstackclient.common import logs
     from openstackclient.common import utils

openstackclient/api/api.py

@@ -17,8 +17,7 @@ import simplejson as json
 
 from keystoneauth1 import exceptions as ks_exceptions
 from keystoneauth1 import session as ks_session
-
+from osc_lib import exceptions
-from openstackclient.common import exceptions
 
 
 class KeystoneSession(object):

openstackclient/api/auth.py

@@ -17,8 +17,8 @@ import argparse
 import logging
 
 from keystoneauth1.loading import base
+from osc_lib import exceptions as exc
 
-from openstackclient.common import exceptions as exc
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/common/clientmanager.py

@@ -20,12 +20,12 @@ import logging
 import pkg_resources
 import sys
 
+from osc_lib import exceptions
 from oslo_utils import strutils
 import requests
 import six
 
 from openstackclient.api import auth
-from openstackclient.common import exceptions
 from openstackclient.common import session as osc_session
 from openstackclient.identity import client as identity_client
 

openstackclient/common/command.py

@@ -18,9 +18,9 @@ import logging
 from cliff import command
 from cliff import lister
 from cliff import show
+from osc_lib import exceptions
 import six
 
-from openstackclient.common import exceptions
 from openstackclient.i18n import _
 
 

openstackclient/compute/client.py

@@ -15,7 +15,8 @@
 
 import logging
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/compute/v2/agent.py

@@ -15,10 +15,10 @@
 
 """Agent action implementations"""
 
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/compute/v2/flavor.py

@@ -15,10 +15,10 @@
 
 """Flavor action implementations"""
 
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/compute/v2/keypair.py

@@ -17,11 +17,12 @@
 
 import io
 import os
-import six
 import sys
 
+from osc_lib import exceptions
+import six
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/compute/v2/server.py

@@ -19,17 +19,17 @@ import argparse
 import getpass
 import io
 import os
-import six
 import sys
 
-from openstackclient.common import command
+from osc_lib import exceptions
+import six
 
 try:
     from novaclient.v2 import servers
 except ImportError:
     from novaclient.v1_1 import servers
 
-from openstackclient.common import exceptions
+from openstackclient.common import command
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/compute/v2/server_backup.py

@@ -17,11 +17,11 @@
 
 import sys
 
+from osc_lib import exceptions
 from oslo_utils import importutils
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/compute/v2/server_group.py

@@ -15,8 +15,9 @@
 
 """Compute v2 Server Group action implementations"""
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/compute/v2/service.py

@@ -15,8 +15,9 @@
 
 """Service action implementations"""
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/identity/common.py

@@ -20,8 +20,8 @@ from keystoneclient.v3 import domains
 from keystoneclient.v3 import groups
 from keystoneclient.v3 import projects
 from keystoneclient.v3 import users
+from osc_lib import exceptions
 
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 
 

openstackclient/identity/v2_0/catalog.py

@@ -13,10 +13,10 @@
 
 """Identity v2 Service Catalog action implementations"""
 
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/identity/v2_0/role.py

@@ -15,12 +15,11 @@
 
 """Identity v2 Role action implementations"""
 
+from keystoneauth1 import exceptions as ks_exc
+from osc_lib import exceptions
 import six
 
-from keystoneauth1 import exceptions as ks_exc
-
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/identity/v2_0/service.py

@@ -16,10 +16,11 @@
 """Service action implementations"""
 
 import argparse
+
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 from openstackclient.identity import common

openstackclient/identity/v3/catalog.py

@@ -13,10 +13,10 @@
 
 """Identity v3 Service Catalog action implementations"""
 
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/identity/v3/mapping.py

@@ -19,8 +19,9 @@ import json
 
 import six
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/identity/v3/token.py

@@ -17,8 +17,9 @@
 
 import six
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 from openstackclient.identity import common

openstackclient/identity/v3/unscoped_saml.py

@@ -17,8 +17,9 @@ The first step of federated auth is to fetch an unscoped token. From there,
 the user can list domains and projects they are allowed to access, and request
 a scoped token."""
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 

openstackclient/image/v2/image.py

@@ -19,10 +19,10 @@ import argparse
 import six
 
 from glanceclient.common import utils as gc_utils
+from osc_lib import exceptions
 
 from openstackclient.api import utils as api_utils
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/network/common.py

@@ -12,10 +12,11 @@
 #
 
 import abc
+
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.i18n import _
 
 

openstackclient/network/v2/address_scope.py

@@ -13,8 +13,9 @@
 
 """Address scope action implementations"""
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 from openstackclient.identity import common as identity_common

openstackclient/network/v2/port.py

@@ -16,8 +16,9 @@
 import argparse
 import logging
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/network/v2/security_group_rule.py

@@ -14,14 +14,15 @@
 """Security Group Rule action implementations"""
 
 import argparse
-import six
 
 try:
     from novaclient.v2 import security_group_rules as compute_secgroup_rules
 except ImportError:
     from novaclient.v1_1 import security_group_rules as compute_secgroup_rules
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+import six
+
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/network/v2/subnet.py

@@ -12,10 +12,12 @@
 #
 
 """Subnet action implementations"""
+
 import copy
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _

openstackclient/shell.py

@@ -26,13 +26,13 @@ from cliff import app
 from cliff import command
 from cliff import complete
 from cliff import help
+from osc_lib import exceptions as exc
 from oslo_utils import importutils
 from oslo_utils import strutils
 
 import openstackclient
 from openstackclient.common import clientmanager
 from openstackclient.common import commandmanager
-from openstackclient.common import exceptions as exc
 from openstackclient.common import logs
 from openstackclient.common import timing
 from openstackclient.common import utils

openstackclient/tests/api/test_api.py

@@ -13,8 +13,9 @@
 
 """Base API Library Tests"""
 
+from osc_lib import exceptions
+
 from openstackclient.api import api
-from openstackclient.common import exceptions
 from openstackclient.tests.api import fakes as api_fakes
 
 

openstackclient/tests/common/test_clientmanager.py

@@ -15,15 +15,15 @@
 
 import json as jsonutils
 import mock
-from requests_mock.contrib import fixture
 
 from keystoneauth1.access import service_catalog
 from keystoneauth1.identity import v2 as auth_v2
 from keystoneauth1 import token_endpoint
+from osc_lib import exceptions as exc
+from requests_mock.contrib import fixture
 
 from openstackclient.api import auth
 from openstackclient.common import clientmanager
-from openstackclient.common import exceptions as exc
 from openstackclient.tests import fakes
 from openstackclient.tests import utils
 

openstackclient/tests/common/test_command.py

@@ -14,8 +14,9 @@
 
 import mock
 
+from osc_lib import exceptions
+
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.tests import fakes as test_fakes
 from openstackclient.tests import utils as test_utils
 

openstackclient/tests/common/test_utils.py

@@ -18,7 +18,8 @@ import uuid
 
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.tests import fakes
 from openstackclient.tests import utils as test_utils

openstackclient/tests/compute/v2/test_agent.py

@@ -16,7 +16,8 @@
 import mock
 
 from mock import call
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.compute.v2 import agent
 from openstackclient.tests.compute.v2 import fakes as compute_fakes
 

openstackclient/tests/compute/v2/test_flavor.py

@@ -15,7 +15,8 @@
 
 import copy
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.compute.v2 import flavor
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/compute/v2/test_hypervisor.py

@@ -15,7 +15,8 @@
 
 import copy
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.compute.v2 import hypervisor
 from openstackclient.tests.compute.v2 import fakes as compute_fakes
 from openstackclient.tests import fakes

openstackclient/tests/compute/v2/test_server.py

@@ -14,9 +14,10 @@
 #
 import getpass
 import mock
-
 from mock import call
-from openstackclient.common import exceptions
+
+from osc_lib import exceptions
+
 from openstackclient.common import utils as common_utils
 from openstackclient.compute.v2 import server
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/compute/v2/test_server_backup.py

@@ -13,7 +13,8 @@
 
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils as common_utils
 from openstackclient.compute.v2 import server_backup
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/compute/v2/test_server_group.py

@@ -15,7 +15,8 @@
 
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.compute.v2 import server_group
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/compute/v2/test_service.py

@@ -13,7 +13,8 @@
 #   under the License.
 #
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.compute.v2 import service
 from openstackclient.tests.compute.v2 import fakes as compute_fakes
 

openstackclient/tests/identity/v2_0/test_role.py

@@ -17,8 +17,8 @@ import copy
 import mock
 
 from keystoneauth1 import exceptions as ks_exc
+from osc_lib import exceptions
 
-from openstackclient.common import exceptions
 from openstackclient.identity.v2_0 import role
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v2_0 import fakes as identity_fakes

openstackclient/tests/identity/v3/test_mappings.py

@@ -16,7 +16,8 @@ import copy
 
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.identity.v3 import mapping
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v3 import fakes as identity_fakes

openstackclient/tests/identity/v3/test_project.py

@@ -16,7 +16,8 @@
 import copy
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.identity.v3 import project
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v3 import fakes as identity_fakes

openstackclient/tests/identity/v3/test_unscoped_saml.py

@@ -12,7 +12,8 @@
 
 import copy
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.identity.v3 import unscoped_saml
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v3 import fakes as identity_fakes

openstackclient/tests/image/v1/test_image.py

@@ -16,7 +16,8 @@
 import copy
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.image.v1 import image
 from openstackclient.tests import fakes
 from openstackclient.tests.image.v1 import fakes as image_fakes

openstackclient/tests/image/v2/test_image.py

@@ -19,7 +19,8 @@ import mock
 import warlock
 
 from glanceclient.v2 import schemas
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils as common_utils
 from openstackclient.image.v2 import image
 from openstackclient.tests import fakes

openstackclient/tests/network/v2/test_address_scope.py

@@ -15,7 +15,8 @@ import copy
 import mock
 
 from mock import call
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.network.v2 import address_scope
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v3 import fakes as identity_fakes_v3

openstackclient/tests/network/v2/test_network.py

@@ -13,9 +13,10 @@
 
 import copy
 import mock
-
 from mock import call
-from openstackclient.common import exceptions
+
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.network.v2 import network
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/network/v2/test_network_segment.py

@@ -13,7 +13,8 @@
 
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.network.v2 import network_segment
 from openstackclient.tests.network.v2 import fakes as network_fakes
 from openstackclient.tests import utils as tests_utils

openstackclient/tests/network/v2/test_port.py

@@ -14,7 +14,8 @@
 import mock
 
 from mock import call
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.common import utils
 from openstackclient.network.v2 import port
 from openstackclient.tests.network.v2 import fakes as network_fakes

openstackclient/tests/network/v2/test_security_group_rule.py

@@ -14,7 +14,8 @@
 import copy
 import mock
 
-from openstackclient.common import exceptions
+from osc_lib import exceptions
+
 from openstackclient.network import utils as network_utils
 from openstackclient.network.v2 import security_group_rule
 from openstackclient.tests.compute.v2 import fakes as compute_fakes

openstackclient/tests/volume/test_find_resource.py

@@ -17,8 +17,8 @@ import mock
 
 from cinderclient.v1 import volume_snapshots
 from cinderclient.v1 import volumes
+from osc_lib import exceptions
 
-from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.tests import utils as test_utils
 from openstackclient.volume import client  # noqa

openstackclient/volume/v2/volume_type.py

@@ -14,10 +14,10 @@
 
 """Volume v2 Type action implementations"""
 
+from osc_lib import exceptions
 import six
 
 from openstackclient.common import command
-from openstackclient.common import exceptions
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _