openstack/python-openstackclient
Code Issues Proposed changes

Merge "trivial: Make better use of argparse"

Browse Source
This commit is contained in:
Zuul 2023-10-31 15:00:24 +00:00 committed by Gerrit Code Review
commit dfcb8b0ee7
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openstackclient/tests/unit/volume/v2/test_volume_type.py
View File

@ -171,6 +171,7 @@ class TestTypeCreate(TestType):
self.new_volume_type.name, self.new_volume_type.name,
] ]
verifylist = [ verifylist = [
('is_public', None),
('project', self.project.id), ('project', self.project.id),
('name', self.new_volume_type.name), ('name', self.new_volume_type.name),
] ]

5
openstackclient/volume/v2/volume_type.py
View File

@ -250,11 +250,14 @@ class CreateVolumeType(command.ShowOne):
raise exceptions.CommandError(msg) raise exceptions.CommandError(msg)
kwargs = {} kwargs = {}
if parsed_args.is_public is not None: if parsed_args.is_public is not None:
kwargs['is_public'] = parsed_args.is_public kwargs['is_public'] = parsed_args.is_public
volume_type = volume_client.volume_types.create( volume_type = volume_client.volume_types.create(
parsed_args.name, description=parsed_args.description, **kwargs parsed_args.name,
description=parsed_args.description,
**kwargs,
) )
volume_type._info.pop('extra_specs') volume_type._info.pop('extra_specs')