3afd2b7ff2
KeyError cause the command "module list --all" failed, fix it, and do refactor to filter private modules and reduce the loop times, add related unit tests and functional tests. Change-Id: Icd77739502e05b5f763a04a92547497bf82d5d63 Closes-Bug: #1661814
95 lines
3.1 KiB
Python
95 lines
3.1 KiB
Python
# Copyright 2013 Nebula Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
"""Module action implementation"""
|
|
|
|
import sys
|
|
|
|
from osc_lib.command import command
|
|
from osc_lib import utils
|
|
import six
|
|
|
|
from openstackclient.i18n import _
|
|
|
|
|
|
class ListCommand(command.Lister):
|
|
_description = _("List recognized commands by group")
|
|
|
|
auth_required = False
|
|
|
|
def take_action(self, parsed_args):
|
|
cm = self.app.command_manager
|
|
groups = cm.get_command_groups()
|
|
groups = sorted(groups)
|
|
columns = ('Command Group', 'Commands')
|
|
|
|
commands = []
|
|
for group in groups:
|
|
command_names = cm.get_command_names(group)
|
|
command_names = sorted(command_names)
|
|
|
|
if command_names != []:
|
|
|
|
# TODO(bapalm): Fix this when cliff properly supports
|
|
# handling the detection rather than using the hard-code below.
|
|
if parsed_args.formatter == 'table':
|
|
command_names = utils.format_list(command_names, "\n")
|
|
|
|
commands.append((group, command_names))
|
|
|
|
return (columns, commands)
|
|
|
|
|
|
class ListModule(command.ShowOne):
|
|
_description = _("List module versions")
|
|
|
|
auth_required = False
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(ListModule, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'--all',
|
|
action='store_true',
|
|
default=False,
|
|
help=_('Show all modules that have version information'),
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
|
|
data = {}
|
|
# Get module versions
|
|
mods = sys.modules
|
|
for k in mods.keys():
|
|
k = k.split('.')[0]
|
|
# Skip private modules and the modules that had been added,
|
|
# like: keystoneclient, keystoneclient.exceptions and
|
|
# keystoneclient.auth
|
|
if not k.startswith('_') and k not in data:
|
|
# TODO(dtroyer): Need a better way to decide which modules to
|
|
# show for the default (not --all) invocation.
|
|
# It should be just the things we actually care
|
|
# about like client and plugin modules...
|
|
if (parsed_args.all or
|
|
# Handle xxxclient and openstacksdk
|
|
(k.endswith('client') or k == 'openstack')):
|
|
try:
|
|
data[k] = mods[k].__version__
|
|
except Exception:
|
|
# Catch all exceptions, just skip it
|
|
pass
|
|
|
|
return zip(*sorted(six.iteritems(data)))
|