python-openstackclient/fix-backup-incremental-d1c1e6886cf32256.yaml at fb1f841d2de9091c4e672a046c0faf529378366c - python-openstackclient - OpenDev: Free Software Needs Free Tools

openstack/python-openstackclient

Rajat Dhasmana 205bac3caf Fix: incremental volume backup

The incremental volume backup stopped working after we moved from
cinderclient to SDK[1]. This happened because SDK accepts the
``is_incremental`` parameter[2] rather than the ``incremental`` parameter
which is actually passed in the API request and was previously a valid
parameter for cinderclient.

This patch fixes the issue by passing the ``is_incremental`` field instead
of ``incremental`` from the OSC side which adds the ``incremental`` parameter
in the API request.

Request body after the fix:

'{"backup": {"name": null, "description": null, "volume_id": "<vol-id>",
"force": false, "container": null, "incremental": true}}'

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/889748
[2] 10e5e20fc0/openstack/block_storage/v2/backup.py (L126-L134)

Closes-Bug: #2070080
Change-Id: I89bd3d2751267ec39f4dbd664b7873ab87a9ac6c

2024-07-01 21:11:46 +05:30

8 lines

206 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     Fixed issue with creating incremental volume backup.
     Previously, ``incremental`` value was not passed in the
     API request which is now included in the backup
     create request.