python-openstackclient/openstackclient/compute/v2/host.py
Benoît Knecht fc76db0def compute: host: expand kwargs in host_set() call
`host_set()` expects `status` and `maintenance_mode` as keyword
arguments, but in `SetHost.take_action()`, it is called without
expanding the keyword arguments.

So it's called as

```
host_set(host, {'status': 'enable'})
```

instead of

```
host_set(host, status='enable')
```

Change-Id: If0b37ac60091161a892bfc694fce31a988f66005
Task: 23023
2018-07-20 10:37:34 +02:00

132 lines
3.8 KiB
Python

# Copyright 2012-2013 OpenStack Foundation
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
"""Host action implementations"""
from osc_lib.command import command
from osc_lib import utils
from openstackclient.i18n import _
class ListHost(command.Lister):
_description = _("List hosts")
def get_parser(self, prog_name):
parser = super(ListHost, self).get_parser(prog_name)
parser.add_argument(
"--zone",
metavar="<zone>",
help=_("Only return hosts in the availability zone")
)
return parser
def take_action(self, parsed_args):
compute_client = self.app.client_manager.compute
columns = (
"Host Name",
"Service",
"Zone"
)
data = compute_client.api.host_list(parsed_args.zone)
return (columns,
(utils.get_dict_properties(
s, columns,
) for s in data))
class SetHost(command.Command):
_description = _("Set host properties")
def get_parser(self, prog_name):
parser = super(SetHost, self).get_parser(prog_name)
parser.add_argument(
"host",
metavar="<host>",
help=_("Host to modify (name only)")
)
status = parser.add_mutually_exclusive_group()
status.add_argument(
'--enable',
action='store_true',
help=_("Enable the host")
)
status.add_argument(
'--disable',
action='store_true',
help=_("Disable the host")
)
maintenance = parser.add_mutually_exclusive_group()
maintenance.add_argument(
'--enable-maintenance',
action='store_true',
help=_("Enable maintenance mode for the host")
)
maintenance.add_argument(
'--disable-maintenance',
action='store_true',
help=_("Disable maintenance mode for the host")
)
return parser
def take_action(self, parsed_args):
kwargs = {}
if parsed_args.enable:
kwargs['status'] = 'enable'
if parsed_args.disable:
kwargs['status'] = 'disable'
if parsed_args.enable_maintenance:
kwargs['maintenance_mode'] = 'enable'
if parsed_args.disable_maintenance:
kwargs['maintenance_mode'] = 'disable'
compute_client = self.app.client_manager.compute
compute_client.api.host_set(
parsed_args.host,
**kwargs
)
class ShowHost(command.Lister):
_description = _("Display host details")
def get_parser(self, prog_name):
parser = super(ShowHost, self).get_parser(prog_name)
parser.add_argument(
"host",
metavar="<host>",
help=_("Name of host")
)
return parser
def take_action(self, parsed_args):
compute_client = self.app.client_manager.compute
columns = (
"Host",
"Project",
"CPU",
"Memory MB",
"Disk GB"
)
data = compute_client.api.host_show(parsed_args.host)
return (columns,
(utils.get_dict_properties(
s, columns,
) for s in data))