openstack/rally-openstack
Code Issues Proposed changes

Merge "Remove unnecessary shell=True in subprocess calls"

Browse Source
This commit is contained in:
Jenkins 2015-11-30 17:28:26 +00:00 committed by Gerrit Code Review
commit 3e03a17426
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/functional/utils.py
View File

@ -74,8 +74,8 @@ class Rally(object):
def __init__(self, fake=False, force_new_db=False):
if not os.path.exists(DEPLOYMENT_FILE):
subprocess.call("rally deployment config > %s" % DEPLOYMENT_FILE,
shell=True)
subprocess.call(["rally", "deployment", "config"],
stdout=open(DEPLOYMENT_FILE, "w"))
# NOTE(sskripnick): we should change home dir to avoid races
# and do not touch any user files in ~/.rally