openstack/rally-openstack
Code Issues Proposed changes

[validation] Use jsonschema validator in Hook and Trigger plugins

Browse Source 
Change-Id: I62ede78d76bd0a70d1a9149e849c47399a03ebb7
This commit is contained in:
Anton Studenov 2017-04-04 14:12:13 +03:00
parent 0a3d395535
commit 56cb4d211a
1 changed files with 9 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
tests/unit/plugins/openstack/hook/test_fault_injection.py
View File

@ -15,30 +15,16 @@
import ddt
import jsonschema
import mock
from os_faults.api import error
from rally import consts
from rally.plugins.openstack.hook import fault_injection
from rally.task import hook
from tests.unit import fakes
from tests.unit import test
def create_config(**kwargs):
return {
"name": "fault_injection",
"args": kwargs,
"trigger": {
"name": "event",
"args": {
"unit": "iteration",
"at": [10]
}
}
}
@ddt.ddt
class FaultInjectionHookTestCase(test.TestCase):
@ -46,19 +32,18 @@ class FaultInjectionHookTestCase(test.TestCase):
super(FaultInjectionHookTestCase, self).setUp()
self.task = {"deployment_uuid": "foo_uuid"}
@ddt.data((create_config(action="foo"), True),
(create_config(action="foo", verify=True), True),
(create_config(action=10), False),
(create_config(action="foo", verify=10), False),
(create_config(), False))
@ddt.data((dict(action="foo"), True),
(dict(action="foo", verify=True), True),
(dict(action=10), False),
(dict(action="foo", verify=10), False),
(dict(), False))
@ddt.unpack
def test_config_schema(self, config, valid):
results = hook.Hook.validate("fault_injection", None, None, config)
if valid:
fault_injection.FaultInjectionHook.validate(config)
self.assertEqual([], results)
else:
self.assertRaises(jsonschema.ValidationError,
fault_injection.FaultInjectionHook.validate,
config)
self.assertEqual(1, len(results))
@mock.patch("rally.common.objects.Deployment.get")
@mock.patch("os_faults.human_api")