From 6158c1139c0a4d88cab74481c5cbfc8be398f481 Mon Sep 17 00:00:00 2001 From: Andrey Kurilin Date: Tue, 24 Apr 2018 18:45:34 +0300 Subject: [PATCH] Remove atomic timer from nova.bind_actions method Method `_bind_actions` creates an inner rally entity for further launching different kind of actions. It is redundant to calculate how much time takes initialization of one inner class + calling several inner methods. It takes ms. Change-Id: Id5224138e3dcdd6815e7ee00ae5b16200fb7f2d9 --- CHANGELOG.rst | 8 ++++++++ rally_openstack/scenarios/nova/utils.py | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 491cd6cf..e17351f1 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -38,6 +38,14 @@ Changed Also, the CI is extended to check ability to build Docker image for any of changes. +Removed +~~~~~~~ + +* Calculation of the duration for "nova.bind_actions" action. It shows + only duration of initialization Rally inner class and can be easily + misunderstood as some kind of "Nova operation". + Affects 1 inner scenario "NovaServers.boot_and_bounce_server". + Fixed ~~~~~ diff --git a/rally_openstack/scenarios/nova/utils.py b/rally_openstack/scenarios/nova/utils.py index 75ea7f07..a9363854 100644 --- a/rally_openstack/scenarios/nova/utils.py +++ b/rally_openstack/scenarios/nova/utils.py @@ -1078,7 +1078,6 @@ class NovaScenario(scenario.OpenStackScenario): """ return self.admin_clients("nova").aggregates.delete(aggregate) - @atomic.action_timer("nova.bind_actions") def _bind_actions(self): actions = ["hard_reboot", "soft_reboot", "stop_start", "rescue_unrescue", "pause_unpause", "suspend_resume",