openstack/rally-openstack
Code Issues Proposed changes

Switch scenarios plugins to plugin base

Browse Source 
This patch finishes work on switching all plugin types
to the single code base. This reduce amount of code and unifies
all plugins which makes it simple to work on any kind of common
plugin functionality: Deprecation, Info, Validation and so on..
In this patch:
* Scenario.meta was removed and now MetaMixin is used
* ScenarioGroups are removed
  This reduce framework complexity. One thing less that you
  should know and understand to start.
* Scenario plugins can be explit set through configure()
  ** Unified with other kind of plugins
  ** Flexibility it is simpler to move and rename plugins
     with deprecation
* Remove all unused Scenario methods

* Improve rally.info substitution
it's okay if we specify each part of name of the plguin

Future steps (not in this patch) are:
* Refactor plugin info and reduce copy paste inside that module
* Refactor atomic action (make the work for context too)
* Refactor validation (make scenario validation generic enough
to work with all types of plugins)

Change-Id: Ibecb8006ebb5d670bcf4519e9f0d6a505e385a1a
This commit is contained in:
Boris Pavlovic 2015-08-18 16:29:08 -07:00
parent 37fd08ee44
commit fb661825fc
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/doc/test_task_samples.py
View File

@ -59,13 +59,11 @@ class TaskSampleTestCase(test.TestCase):
else: else:
scenarios.update(task_config.keys()) scenarios.update(task_config.keys())
# TODO(boris-42): We should refactor scenarios framework add "_" to missing = set(s.get_name() for s in scenario.Scenario.get_all())
# all non-benchmark methods.. Then this test will pass. missing -= scenarios
missing = set(scenario.Scenario.list_benchmark_scenarios()) - scenarios
# check missing scenario is not from plugin # check missing scenario is not from plugin
missing = [s for s in list(missing) missing = [s for s in list(missing)
if scenario.Scenario.get_by_name(s.split(".")[0]). if scenario.Scenario.get(s).__module__.startswith("rally")]
__module__.startswith("rally")]
self.assertEqual(missing, [], self.assertEqual(missing, [],
"These scenarios don't have samples: %s" % missing) "These scenarios don't have samples: %s" % missing)