rally-openstack/tests/unit/test_test_ddt.py
Chris St. Pierre d1b70e365b Add AST checker for missing @ddt.ddt decorators
If a test case class has functions decorated with a ddt decorator, but
is not itself decorated with @ddt.ddt, then tests don't run
properly. This adds an AST checker to ensure that a class that
contains functions decorated with a ddt decorator is properly
decorated. It also includes unit tests for the checker itself.

Change-Id: If7186d1f8b9a1967e7af55d86cd568e323aeccf7
2015-11-04 12:21:51 -06:00

49 lines
1.4 KiB
Python

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import ast
from tests.unit import test
from tests.unit import test_ddt
class DDTDecoratorCheckerTestCase(test.TestCase):
def test_pass(self):
code = """
@ddt.ddt
class Test(object):
@ddt.data({})
def test_func(self):
pass
"""
tree = ast.parse(code).body[0]
visitor = test_ddt.DDTDecoratorChecker()
visitor.visit(tree)
self.assertEqual(visitor.errors, {})
def test_fail(self):
code = """
class Test(object):
@ddt.data({})
def test_func(self):
pass
"""
tree = ast.parse(code).body[0]
visitor = test_ddt.DDTDecoratorChecker()
visitor.visit(tree)
self.assertEqual(
visitor.errors,
{"Test": {"lineno": 3,
"message": "Class Test has functions that use DDT, "
"but is not decorated with `ddt.ddt`"}})