openstack/requirements
Code Issues Proposed changes

Stop configuring install_command in tox.

Browse Source 
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

Change-Id: I9130a9202515ac7b88e7b6a99dbb6a756ac65895
This commit is contained in:
Daniel Bengtsson 2019-11-15 12:13:07 +01:00
parent 1a2688e23e
commit 11f05d4904
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tox.ini
View File

@ -7,8 +7,6 @@ ignore_basepython_conflict=true
[testenv] [testenv]
basepython = python3 basepython = python3
usedevelop = True usedevelop = True
install_command = pip install -U {opts} {packages}
setenv = VIRTUAL_ENV={envdir}
deps = -c{toxinidir}/upper-constraints.txt deps = -c{toxinidir}/upper-constraints.txt
-r{toxinidir}/requirements.txt -r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt -r{toxinidir}/test-requirements.txt
@ -33,7 +31,6 @@ commands = update-requirements {posargs}
[testenv:generate] [testenv:generate]
# Generate needs an unconstrained install to get new dependencies # Generate needs an unconstrained install to get new dependencies
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/requirements.txt deps = -r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt -r{toxinidir}/test-requirements.txt
commands = generate-constraints {posargs} commands = generate-constraints {posargs}
@ -85,7 +82,6 @@ commands = sphinx-build -W -b html doc/source doc/build/html
[testenv:pip-install] [testenv:pip-install]
recreate = True recreate = True
deps = . deps = .
install_command = pip install {opts} {packages}
commands = python {toxinidir}/tools/check-install.py commands = python {toxinidir}/tools/check-install.py
[testenv:requirements-check] [testenv:requirements-check]