From baec05f65ebaa5b6427da69dbf509171d2da9782 Mon Sep 17 00:00:00 2001 From: Darragh Bailey Date: Fri, 13 Jul 2018 19:25:04 +0100 Subject: [PATCH] Adding fixtures-git to global requirements To allow other openstack projects to use fixtures-git for their testing it is necessary to be part of the global-requirements. This was spun out of git-upstream to add as a common place for any fixtures for working with git repos both local and remote to perform functional/acceptance testing. Is the library actively maintained? Yes - I'm the author and this was preivously part of git-upstream. Is the library good code? Partially - the code should be clear as python fixtures is a relatively straight forward API to follow but documentation is yet to be added. Is the library python 3 compatible? Yes Is the library license compatible? Yes - Apache 2.0 Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? No - but as it's a test fixture it shouldn't be required to be installed as a dependency of any application using it for testing. Is the function of this library already covered by other libraries in global-requirements.txt? I don't believe so, was unable to locate any other testing fixtures for testing with git. Is the library required for OpenStack project or related dev or infrastructure setup? (Answer to this should be Yes, of course) Which? Yes - git-upstream will switch to using this library instead of maintaining it intally. Change-Id: I53b04ce5b74e13f35f0fa8e9e35d450d7c421a5e --- global-requirements.txt | 1 + upper-constraints.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/global-requirements.txt b/global-requirements.txt index e40ccbf644..736919b522 100644 --- a/global-requirements.txt +++ b/global-requirements.txt @@ -388,6 +388,7 @@ django-nose # BSD doc8 # Apache-2.0 Pygments # BSD license fixtures # Apache-2.0/BSD +fixtures-git # Apache-2.0 freezegun # Apache-2.0 gabbi # Apache-2.0 kafka-python # Apache-2.0 diff --git a/upper-constraints.txt b/upper-constraints.txt index 01d06aaa3a..f327373f1a 100644 --- a/upper-constraints.txt +++ b/upper-constraints.txt @@ -182,6 +182,7 @@ asyncio===3.4.3;python_version=='3.5' tzlocal===1.5.1 python-novaclient===10.3.0 bcrypt===3.1.4 +fixtures-git===0.1.0 os-client-config===1.31.2 XStatic-Angular-Gettext===2.3.8.0 XStatic-Hogan===2.0.0.2