openstack/requirements
Code Issues Proposed changes

Add new dependency for tabulate library

Browse Source 
* Is the library actively maintained?

There have been three releases so far in 2019 and the last commit to the
repo was 2 days ago. Issues appear to be addressed at a reasonable rate.

* Is the library good code?

Code appears to be fine, and there are unit tests tox targets for all of
our supported Python versions.

* Is the library python 3 compatible?

Yes, package metadata declares 2.7, 3.5, 3.6, and 3.7. Tox also has
targets for all of these versions. Contains compatibility code for the
places where it needs to handle things differently between versions.

* Is the library license compatible?

Yes, library is under the MIT permissive license.

* Is the library already packaged in the distros we target (Ubuntu
latest / Fedora latest)?

Fedora has python3-tabulate. RHEL has python[2|34|36]-tabulate. Ubuntu
has python2-tabulate and python3-tabulate.

* Is the function of this library already covered by other libraries in
global-requirements.txt?

Yes, this would be an alternative to PrettyTable. PrettyTable has not
had a release since 2013 and is starting to emit DeprecationWarnings due
to Python changes. Various attempts have been made to get a fork going,
but it doesn't appear any of them have been very successful.

* Is the library required for OpenStack project or related dev or
infrastructure setup? (Answer to this should be Yes, of course) Which?

There are quite a few OpenStack projects using PrettyTable that would
(and probably should) switch over to using tabulate. Some existing
projects using PrettyTable that would be candidates for switching are
cliff, cinder, election, glance, and many more.

* If the library release is managed by the Openstack release process
does it use the cycle-with-intermediary release type?

N/A

Change-Id: I80eb63c2ed01659990ca5506be7e0e246c9586ba
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2019-11-13 09:12:48 -06:00
parent 4f16a404a0
commit 9bbb17864b
No known key found for this signature in database
GPG Key ID: CE7EE4BFAF8D70C8
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
global-requirements.txt
View File

@ -476,6 +476,7 @@ sphinxcontrib-programoutput # BSD license
sphinxcontrib-svg2pdfconverter # BSD License
stestr!=2.3.0 # Apache-2.0
sushy!=1.9.0 # Apache-2.0
tabulate # MIT
testrepository # Apache-2.0/BSD
testresources # Apache-2.0/BSD
testscenarios # Apache-2.0/BSD

1
upper-constraints.txt
View File

@ -7,6 +7,7 @@ restructuredtext-lint===1.3.0
netmiko===2.4.2
instack-undercloud===9.5.1
PasteDeploy===2.0.1
tabulate===0.8.5
typing===3.7.4.1
python-saharaclient===2.3.0
python-hnvclient===0.1.0