From ccb67adf94ea160ab128c64849214383bc55e66f Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Thu, 9 Aug 2018 07:16:56 +0200 Subject: [PATCH] Add pydot to global-requirements.txt Recently pydot3 was introduced which was a fork of pydot introducing Python 3.x compatibility. Since then pydot has added python 3.x support and seems to be more regularly releasing than pydot3, which hasn't seen a single release since two years. Furthermore networkx is actually requiring pydot and will refuse to run with pydot3 installed so there isn't much choice. Is the library actively maintained? Last release Dec 25, 2017 and no indications of project being abandoned. Is the library good code? Merging the pydot3 changes it should be as good as the pydot3 addition. Is the library license compatible? Yes. Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? Yes. Is the function of this library already covered by other libraries in global-requirements.txt? It was covered by pydot3 which this one is superseding. Is the library required for OpenStack project or related dev or infrastructure setup? (Answer to this should be Yes, of course) Which? Taskflow needs pydot for executing its networkx graph generation unit test. If the library release is managed by the Openstack release process does it use the cycle-with-intermediary release type? No. Change-Id: Ie0607c86259bda5483b2bf4f6f9a87f93cd9be0e --- global-requirements.txt | 1 + upper-constraints.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/global-requirements.txt b/global-requirements.txt index e343870a1b..9c0789f737 100644 --- a/global-requirements.txt +++ b/global-requirements.txt @@ -217,6 +217,7 @@ etcd3 # Apache-2.0 etcd3gw # Apache-2.0 typing # PSF voluptuous # BSD License +pydot # MIT License pydotplus # MIT License crc16 # LGPLv3+ pyzabbix # LGPL diff --git a/upper-constraints.txt b/upper-constraints.txt index 94b63df418..9906e29dd6 100644 --- a/upper-constraints.txt +++ b/upper-constraints.txt @@ -536,3 +536,4 @@ XStatic-D3===3.5.17.0 actdiag===0.5.4 sysv-ipc===1.0.0 scikit-learn===0.19.2 +pydot===1.2.4