openstack/requirements
Code Issues Proposed changes

Adding faker to global requirements

Browse Source 
fixtures-git uses faker to generate fake text for inserting in to files
when building test git repos for tools that wish to test with git.

Is the library actively maintained?
Yes - https://github.com/joke2k/faker
They appear to have made regular releases since 2016 averaging ~2 per
month.

Is the library good code?
Yes - Appears to be relatively straight forward to extend suggesting a
nice simple design and the documentation appears to cover most of the
different types of fake data in reasonable detail.

Is the library python 3 compatible?
Yes - though only for >=3.4
da96379c07/setup.py (L43)

Is the library license compatible?
Yes - MIT

Is the library already packaged in the distros we target (Ubuntu latest
/ Fedora latest)?

Fedora - Present since Fedora 27
Ubuntu - Present since 17.10

Is the function of this library already covered by other libraries in
global-requirements.txt?

I don't believe so, was unable to locate any other random text
generators.

Is the library required for OpenStack project or related dev or
infrastructure setup? (Answer to this should be Yes, of course) Which?

Yes - fixtures-git uses it directly to generate text to be used for
testing by developer tools working with git repositories such as
git-upstream.

Change-Id: Ic1c0412fb1473465977af8244b3e61060296e7a1
This commit is contained in:
Darragh Bailey 2018-06-12 22:17:25 +01:00
parent 25e3c75a3b
commit b74bd9ecc6
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
global-requirements.txt
View File

@ -57,6 +57,7 @@ enum34;python_version=='2.7' or python_version=='2.6' or python_version=='3.3'
eventlet!=0.18.3,!=0.20.1,!=0.21.0,!=0.23.0 # MIT
exabgp # BSD
extras # MIT
faker # MIT
falcon # Apache-2.0
Flask!=0.11,<1.0 # BSD
flask-keystone # Apache-2.0

2
lower-constraints.txt
View File

@ -282,6 +282,7 @@ exabgp===4.0.4
sphinxcontrib-httpdomain===1.3.0
metalsmith===0.3.0
thriftpy===0.3.9
text-unidecode===1.2
murano-pkg-check===0.3.0
oslo.vmware===2.17.0
sqlalchemy-migrate===0.11.0
@ -354,6 +355,7 @@ PyNaCl===1.1.2
osc-lib===1.10.0
osc-placement===1.0.0
python-consul===0.4.7
Faker===0.8.16
seqdiag===0.9.5
numpy===1.13.3
repoze.who===2.3

2
upper-constraints.txt
View File

@ -280,6 +280,7 @@ exabgp===4.0.6
sphinxcontrib-httpdomain===1.6.1
metalsmith===0.4.0
thriftpy===0.3.9;python_version=='2.7'
text-unidecode===1.2
murano-pkg-check===0.3.0
oslo.vmware===2.29.2
sqlalchemy-migrate===0.11.0
@ -353,6 +354,7 @@ sphinxmark===0.1.19
PyNaCl===1.2.1
osc-lib===1.10.0
python-consul===1.0.1
Faker===0.8.16
more-itertools===4.2.0
seqdiag===0.9.5
numpy===1.14.5