Log inner_exception in test runs

Just like in nodepool, it's useful to get the actual traceback in the
output for inner exceptions when you hit an exception in a test case.

Change-Id: I1d5723390772011a1ba290596c2b0d13e9431fcc

shade/exc.py

@@ -21,6 +21,8 @@ log = _log.setup_logging(__name__)
 
 class OpenStackCloudException(Exception):
 
+    log_inner_exceptions = False
+
     def __init__(self, message, extra_data=None):
         args = [message]
         if extra_data:
@@ -44,6 +46,8 @@ class OpenStackCloudException(Exception):
             message = "%s (Inner Exception: %s)" % (
                 message,
                 str(self.inner_exception[1]))
+        if self.log_inner_exceptions:
+            self.log_error()
         return message
 
 

shade/tests/unit/base.py

@@ -40,3 +40,7 @@ class TestCase(base.TestCase):
         self.sleep_fixture = self.useFixture(fixtures.MonkeyPatch(
                                              'time.sleep',
                                              _nosleep))
+        # Getting the inner exceptions in the test log is super useful
+        self.useFixture(fixtures.MonkeyPatch(
+            'shade.exc.OpenStackCloudException.log_inner_exceptions',
+            True))