openstack/shade
Code Issues Proposed changes

Improve test coverage: private extension API

Browse Source 
Add tests for querying for Nova extensions with our
private API methods.

Change-Id: If7ab721222c0643a320a067ee4d7f8b512b83eff
This commit is contained in:
David Shrewsbury 2015-12-08 11:07:48 -05:00
parent f0440f80b7
commit 8696fbdd76
1 changed files with 62 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
shade/tests/unit/test_shade.py
View File

@ -534,3 +534,65 @@ class TestShade(base.TestCase):
for count in _utils._iterate_timeout(0.1, message, wait=1):
pass
mock_sleep.assert_called_with(1.0)
@mock.patch.object(shade.OpenStackCloud, 'nova_client')
def test__nova_extensions(self, mock_nova):
body = {
'extensions': [
{
"updated": "2014-12-03T00:00:00Z",
"name": "Multinic",
"links": [],
"namespace": "http://openstack.org/compute/ext/fake_xml",
"alias": "NMN",
"description": "Multiple network support."
},
{
"updated": "2014-12-03T00:00:00Z",
"name": "DiskConfig",
"links": [],
"namespace": "http://openstack.org/compute/ext/fake_xml",
"alias": "OS-DCF",
"description": "Disk Management Extension."
},
]
}
mock_nova.client.get.return_value = ('200', body)
extensions = self.cloud._nova_extensions()
mock_nova.client.get.assert_called_once_with(url='/extensions')
self.assertEqual(set(['NMN', 'OS-DCF']), extensions)
@mock.patch.object(shade.OpenStackCloud, 'nova_client')
def test__nova_extensions_fails(self, mock_nova):
mock_nova.client.get.side_effect = Exception()
with testtools.ExpectedException(
exc.OpenStackCloudException,
"Error fetching extension list for nova"
):
self.cloud._nova_extensions()
@mock.patch.object(shade.OpenStackCloud, 'nova_client')
def test__has_nova_extension(self, mock_nova):
body = {
'extensions': [
{
"updated": "2014-12-03T00:00:00Z",
"name": "Multinic",
"links": [],
"namespace": "http://openstack.org/compute/ext/fake_xml",
"alias": "NMN",
"description": "Multiple network support."
},
{
"updated": "2014-12-03T00:00:00Z",
"name": "DiskConfig",
"links": [],
"namespace": "http://openstack.org/compute/ext/fake_xml",
"alias": "OS-DCF",
"description": "Disk Management Extension."
},
]
}
mock_nova.client.get.return_value = ('200', body)
self.assertTrue(self.cloud._has_nova_extension('NMN'))
self.assertFalse(self.cloud._has_nova_extension('invalid'))