openstack/shade
Code Issues Proposed changes

Remove extra unneeded API calls

Browse Source 
The create and update calls to nova security groups return the security
group. There is no need to issue a GET.

Change-Id: I068ae5b46954d0c3b0c8be67b80f3eed1be1f55b
This commit is contained in:
Monty Taylor 2017-04-18 13:57:58 -05:00
parent 4c67e76376
commit afed15f371
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
2 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
shade/openstackcloud.py
View File

@ -6803,10 +6803,6 @@ class OpenStackCloud(_normalize.Normalizer):
'security_group': {
'name': name, 'description': description}
})
# TODO(mordred) Remove this, it's a waste of a call. It's here for
# now for consistency with novaclient
group = self._compute_client.get(
'/os-security-groups/{id}'.format(id=group['id']))
return self._normalize_secgroup(group)
def delete_security_group(self, name_or_id):
@ -6888,10 +6884,6 @@ class OpenStackCloud(_normalize.Normalizer):
group = self._compute_client.put(
'/os-security-groups/{id}'.format(id=group['id']),
json={'security-group': kwargs})
# TODO(mordred) Remove this, it's a waste of a call. It's here for
# now for consistency with novaclient
group = self._compute_client.get(
'/os-security-groups/{id}'.format(id=group['id']))
return self._normalize_secgroup(group)
def create_security_group_rule(self,

8
shade/tests/unit/test_security_groups.py
View File

@ -173,10 +173,6 @@ class TestSecurityGroups(base.RequestsMockTestCase):
'name': group_name,
'description': group_desc,
}})),
dict(method='GET',
uri='{endpoint}/os-security-groups/2'.format(
endpoint=fakes.COMPUTE_ENDPOINT),
json={'security_group': new_group}),
])
self.cloud.secgroup_source = 'nova'
@ -221,10 +217,6 @@ class TestSecurityGroups(base.RequestsMockTestCase):
uri='{endpoint}/os-security-groups/2'.format(
endpoint=fakes.COMPUTE_ENDPOINT),
json={'security_group': update_return}),
dict(method='GET',
uri='{endpoint}/os-security-groups/2'.format(
endpoint=fakes.COMPUTE_ENDPOINT),
json={'security_group': update_return}),
])
r = self.cloud.update_security_group(nova_grp_obj.id, name=new_name)