openstack/shade
Code Issues Proposed changes

Remove hacking select line

Browse Source 
Contrary to popular belief, this does not mean "also check this".
It means "only check this and don't check anything else".  So this
was testing _only_ H321.

Change-Id: I8ae173e62d57232cec1bf751004fe4213214353b
This commit is contained in:
James E. Blair 2015-06-03 10:37:17 -07:00 committed by Monty Taylor
parent 9673c36c2b
commit d5d539da81
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
shade/__init__.py
View File

@ -331,7 +331,7 @@ class OpenStackCloud(object):
self.log.debug("keystone auth plugin failure", exc_info=True) self.log.debug("keystone auth plugin failure", exc_info=True)
raise OpenStackCloudException( raise OpenStackCloudException(
"Could not find auth plugin: {plugin}".format( "Could not find auth plugin: {plugin}".format(
plugin=self.auth_type)) plugin=self.auth_type))
try: try:
keystone_auth = auth_plugin(**self.auth) keystone_auth = auth_plugin(**self.auth)
except Exception as e: except Exception as e:
@ -1882,7 +1882,7 @@ class OpenStackCloud(object):
self.log.debug( self.log.debug(
"swift object up to date: {container}/{name}".format( "swift object up to date: {container}/{name}".format(
container=container, name=name)) container=container, name=name))
return False return False
def create_object( def create_object(
@ -2336,7 +2336,7 @@ class OperatorCloud(OpenStackCloud):
_tasks.MachinePortDelete( _tasks.MachinePortDelete(
port_id=( port_id=(
self.ironic_client.port.get_by_address(nic['mac']) self.ironic_client.port.get_by_address(nic['mac'])
))) )))
except Exception as e: except Exception as e:
self.log.debug( self.log.debug(

1
tox.ini
View File

@ -33,7 +33,6 @@ commands = python setup.py testr --coverage --testr-args='{posargs}'
[flake8] [flake8]
# Infra does not follow hacking, nor the broken E12* things # Infra does not follow hacking, nor the broken E12* things
ignore = E123,E125,H ignore = E123,E125,H
select = H231
show-source = True show-source = True
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build