openstack/shade
Code Issues Proposed changes

Timeout too aggressive for inspection tests

Browse Source 
The new ironic inspection tests has a timeout that appears may
be too aggressively low, which may be causing the iterator to give
up before yielding even once, on a random basis.

Change-Id: I18d447e092c74e21edcc7f90f36112d8c87ffee7
This commit is contained in:
David Shrewsbury 2015-11-01 13:31:09 -05:00
parent ba2b3d2181
commit e2f0253547
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
shade/tests/unit/test_shade_operator.py
View File

@ -378,7 +378,7 @@ class TestShadeOperator(base.TestCase):
self.cloud.inspect_machine,
machine_uuid,
wait=True,
timeout=0.001)
timeout=1)
@mock.patch.object(shade.OperatorCloud, 'ironic_client')
def test_inspect_machine_failed(self, mock_client):
@ -469,7 +469,7 @@ class TestShadeOperator(base.TestCase):
)
return_value = self.cloud.inspect_machine(
machine_uuid, wait=True, timeout=0.001)
machine_uuid, wait=True, timeout=1)
self.assertTrue(mock_client.node.set_provision_state.called)
self.assertEqual(
mock_client.node.set_provision_state.call_count, 3)
@ -500,7 +500,7 @@ class TestShadeOperator(base.TestCase):
manageable_machine])
return_value = self.cloud.inspect_machine(
machine_uuid, wait=True, timeout=0.001)
machine_uuid, wait=True, timeout=1)
self.assertDictEqual(expected_return_value, return_value)
@mock.patch.object(shade.OperatorCloud, 'ironic_client')
@ -532,7 +532,7 @@ class TestShadeOperator(base.TestCase):
self.cloud.inspect_machine,
machine_uuid,
wait=True,
timeout=0.001)
timeout=1)
self.assertEqual(
mock_client.node.set_provision_state.call_count, 1)
self.assertEqual(mock_client.node.get.call_count, 3)