From dfbb6f546756479ebe3c8803910fce493b09db3c Mon Sep 17 00:00:00 2001 From: Riccardo Pittau Date: Tue, 5 May 2020 11:20:33 +0200 Subject: [PATCH] Add pep8 import order check Set flake8-import-order version to 0.17.1 Full py3 compatible version. Add all Python3 modules to stdlib list. Change-Id: I3f8fb265842df0ea72e6dfa3eea23c934258d864 --- lower-constraints.txt | 1 + sushy_oem_idrac/tests/unit/test_manager.py | 2 +- sushy_oem_idrac/tests/unit/test_root.py | 2 +- test-requirements.txt | 1 + tox.ini | 3 +++ 5 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lower-constraints.txt b/lower-constraints.txt index d8d6192..e5afb07 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -7,6 +7,7 @@ dulwich==0.15.0 extras==1.0.0 fixtures==3.0.0 flake8==2.5.5 +flake8-import-order==0.17.1 hacking==3.0.0 imagesize==0.7.1 iso8601==0.1.11 diff --git a/sushy_oem_idrac/tests/unit/test_manager.py b/sushy_oem_idrac/tests/unit/test_manager.py index 7dbcbc6..895b14c 100644 --- a/sushy_oem_idrac/tests/unit/test_manager.py +++ b/sushy_oem_idrac/tests/unit/test_manager.py @@ -14,8 +14,8 @@ # under the License. import json -import mock +import mock from oslotest.base import BaseTestCase import sushy from sushy.resources.manager import manager diff --git a/sushy_oem_idrac/tests/unit/test_root.py b/sushy_oem_idrac/tests/unit/test_root.py index dca1d1b..561d5ce 100644 --- a/sushy_oem_idrac/tests/unit/test_root.py +++ b/sushy_oem_idrac/tests/unit/test_root.py @@ -14,8 +14,8 @@ # under the License. import json -import mock +import mock from oslotest.base import BaseTestCase from sushy import main diff --git a/test-requirements.txt b/test-requirements.txt index 280645f..a00523b 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -12,6 +12,7 @@ oslotest>=3.2.0 # Apache-2.0 stestr>=2.0.0 # Apache-2.0 testscenarios>=0.4 # Apache-2.0/BSD testtools>=2.2.0 # MIT +flake8-import-order>=0.17.1 # LGPLv3 # releasenotes reno>=2.5.0 # Apache-2.0 diff --git a/tox.ini b/tox.ini index 0ecbf48..6d68ef7 100644 --- a/tox.ini +++ b/tox.ini @@ -60,6 +60,9 @@ ignore = E123,E125 enable-extensions=H106,H203,H204,H205,H210,H904 builtins = _ exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build +import-order-style = pep8 +application-import-names = sushy_oem_idrac +filename = *.py [testenv:lower-constraints] deps =