openstack/swift
Code Issues Proposed changes

fixed a manpage and added the manpage syntax checker to pep8 jobs

Browse Source 
also a drive-by fix to the bindep job--it doesn't need to install

Change-Id: Ic9b68bc60bfbf21b45a1b7f9d7ff9998e01ddd26
This commit is contained in:
John Dickinson 2018-09-14 17:44:38 -06:00
parent 114220279b
commit 0c97888bcb
4 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.zuul.yaml
View File

@ -277,7 +277,9 @@
- ^test/(functional|probe)/.*$ - ^test/(functional|probe)/.*$
- openstack-tox-pep8: - openstack-tox-pep8:
irrelevant-files: irrelevant-files:
- ^(api-ref|doc|etc|examples|releasenotes)/.*$ - ^(api-ref|etc|examples|releasenotes)/.*$
# Keep doc/manpages -- we want to syntax check them
- ^doc/(requirements.txt|(saio|s3api|source)/.*)$
gate: gate:
jobs: jobs:
# For gate jobs, err towards running more jobs (so, generally avoid # For gate jobs, err towards running more jobs (so, generally avoid
@ -311,7 +313,9 @@
- openstack-tox-lower-constraints - openstack-tox-lower-constraints
- openstack-tox-pep8: - openstack-tox-pep8:
irrelevant-files: irrelevant-files:
- ^(api-ref|doc|etc|examples|releasenotes)/.*$ - ^(api-ref|etc|examples|releasenotes)/.*$
# Keep doc/manpages -- we want to syntax check them
- ^doc/(requirements.txt|(saio|s3api|source)/.*)$
experimental: experimental:
jobs: jobs:
- swift-tox-py27-centos-7 - swift-tox-py27-centos-7

2
bindep.txt
View File

@ -36,3 +36,5 @@ openssl-dev [platform:apk]
libopenssl-devel [platform:suse] libopenssl-devel [platform:suse]
py-cffi [platform:apk] py-cffi [platform:apk]
musl-dev [platform:apk] musl-dev [platform:apk]
man-db [pep8]
man [platform:rpm pep8]

2
doc/manpages/swift-recon.1
View File

@ -129,7 +129,7 @@ cronjob to run the swift-recon-cron script periodically:
More documentation about OpenStack Swift can be found at More documentation about OpenStack Swift can be found at
.BI https://docs.openstack.org/swift/latest/ .BI https://docs.openstack.org/swift/latest/
Also more specific documentation about swift-recon can be found at Also more specific documentation about swift-recon can be found at
.BI https://docs.openstack.org/swift/latest/admin_guide.html#cluster-telemetry-and-monitoring .BI https://docs.openstack.org/swift/latest/admin_guide.html\#cluster-telemetry-and-monitoring

3
tox.ini
View File

@ -69,6 +69,7 @@ commands =
flake8 --filename=swift* bin flake8 --filename=swift* bin
bandit -c bandit.yaml -r swift -n 5 bandit -c bandit.yaml -r swift -n 5
python ./setup.py check --restructuredtext --strict python ./setup.py check --restructuredtext --strict
./.manpages {posargs}
[testenv:py3pep8] [testenv:py3pep8]
basepython = python3 basepython = python3
@ -81,6 +82,7 @@ commands =
flake8 swift test doc setup.py flake8 swift test doc setup.py
flake8 --filename=swift* bin flake8 --filename=swift* bin
python ./setup.py check --restructuredtext --strict python ./setup.py check --restructuredtext --strict
./.manpages {posargs}
[testenv:func] [testenv:func]
basepython = python2.7 basepython = python2.7
@ -146,6 +148,7 @@ show-source = True
# system dependencies are missing, since it's used to tell you what system # system dependencies are missing, since it's used to tell you what system
# dependencies are missing! This also means that bindep must be installed # dependencies are missing! This also means that bindep must be installed
# separately, outside of the requirements files. # separately, outside of the requirements files.
skip_install = True
deps = bindep deps = bindep
commands = bindep test commands = bindep test