openstack/swift
Code Issues Proposed changes

tests: Fix test_cleanup_ondisk_files_commit_window

Browse Source 
`much_older` has to be much older than `older`, or the test gets
flakey. See

- test_cleanup_ondisk_files_reclaim_non_data_files,
- test_cleanup_ondisk_files_reclaim_with_data_files, and
- test_cleanup_ondisk_files_reclaim_with_data_files_legacy_durable

for a more standard definition of "much_older".

Closes-Bug: #2017024
Change-Id: I1eaa501827f4475ddc0c20d82cf0a6d4a5e98f75
This commit is contained in:
Tim Burke 2023-04-20 12:51:03 -07:00
parent 4b6f54d063
commit 105727bc89
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/obj/test_diskfile.py
View File

@ -2810,7 +2810,7 @@ class TestECDiskFileManager(DiskFileManagerMixin, BaseTestCase):
def test_cleanup_ondisk_files_commit_window(self): def test_cleanup_ondisk_files_commit_window(self):
# verify that non-durable files are not reclaimed regardless of # verify that non-durable files are not reclaimed regardless of
# timestamp if written to disk within commit_window # timestamp if written to disk within commit_window
much_older = Timestamp(time() - 1001).internal much_older = Timestamp(time() - 2000).internal
older = Timestamp(time() - 1001).internal older = Timestamp(time() - 1001).internal
newer = Timestamp(time() - 900).internal newer = Timestamp(time() - 900).internal
scenarios = [ scenarios = [