Add s3api headers to allowed_headers by default

Previously, these headers had to be added by operators to their
object-server.conf when enabling swift3 middleware. Since s3api
is now imported into swift we should go ahead and add these headers
by default too.

Change-Id: Ib82e175096716e42aecdab48f01f079e09da6a1d
Signed-off-by: Thiago da Silva <thiago@redhat.com>

doc/manpages/object-server.conf.5

@@ -211,7 +211,7 @@ On PUTs, sync data every n MB. The default is 512.
 .IP "\fBallowed_headers\fR"
 Comma separated list of headers that can be set in metadata on an object.
 This list is in addition to X-Object-Meta-* headers and cannot include Content-Type, etag, Content-Length, or deleted.
-The default is 'Content-Disposition, Content-Encoding, X-Delete-At, X-Object-Manifest, X-Static-Large-Object'.
+The default is 'Content-Disposition, Content-Encoding, X-Delete-At, X-Object-Manifest, X-Static-Large-Object, Cache-Control, Content-Language, Expires, X-Robots-Tag'.
 .IP "\fBauto_create_account_prefix\fR"
 The default is '.'.
 .IP "\fBreplication_server\fR"

doc/source/deployment_guide.rst

@@ -594,6 +594,10 @@ allowed_headers                    Content-Disposition,   Comma separated list o
                                    X-Delete-At,           This list is in addition to
                                    X-Object-Manifest,     X-Object-Meta-* headers and cannot include
                                    X-Static-Large-Object  Content-Type, etag, Content-Length, or deleted
+                                   Cache-Control,
+                                   Content-Language,
+                                   Expires,
+                                   X-Robots-Tag
 auto_create_account_prefix         .                      Prefix used when automatically
                                                           creating accounts.
 replication_server                                        Configure parameter for creating

etc/object-server.conf-sample

@@ -120,9 +120,7 @@ use = egg:swift#object
 # Comma separated list of headers that can be set in metadata on an object.
 # This list is in addition to X-Object-Meta-* headers and cannot include
 # Content-Type, etag, Content-Length, or deleted
-# Note that you may add some extra headers for better S3 compatibility, they are:
-# Cache-Control, Content-Language, Expires, and X-Robots-Tag
-# allowed_headers = Content-Disposition, Content-Encoding, X-Delete-At, X-Object-Manifest, X-Static-Large-Object
+# allowed_headers = Content-Disposition, Content-Encoding, X-Delete-At, X-Object-Manifest, X-Static-Large-Object, Cache-Control, Content-Language, Expires, X-Robots-Tag
 #
 # auto_create_account_prefix = .
 #

swift/common/middleware/s3api/s3api.py

@@ -65,14 +65,6 @@ When using keystone, the config will be::
     both authtoken and s3token will issue the acceptable token to keystone
     (i.e. authenticate twice).
 
-Object-Server Setting
-^^^^^^^^^^^^^^^^^^^^^
-
-To get better compatibility, you may add S3 supported headers (
-Cache-Control, Content-Language, Expires, and X-Robots-Tag), that are
-not supporeted in Swift by default, into allowed_headers option in
-``object-server.conf`` Please see ``object-server.conf`` for more detail.
-
 -----------
 Constraints
 -----------

swift/obj/server.py

@@ -141,6 +141,10 @@ class ObjectController(BaseStorageServer):
             x-delete-at,
             x-object-manifest,
             x-static-large-object,
+            cache-control,
+            content-language,
+            expires,
+            x-robots-tag
         '''
         extra_allowed_headers = [
             header.strip().lower() for header in conf.get(