From 3f857898a93081a1c17dd89850d0ece04569d120 Mon Sep 17 00:00:00 2001 From: Clay Gerrard Date: Thu, 27 Feb 2014 20:27:29 -0800 Subject: [PATCH] Update tox.ini so flake8 works even without hacking The flake8 command (when run from the command line or via vim-flake8) seems to bypass the the normal pep8 [W]arning and [E]rror as well as py[F]lake checks if the project level tox.ini includes a select, but doesn't include them in it's select option (tested on flake8 v2.0 and v2.1). Somehow if hacking is installed these checks always run even if they're not explicitly listed in the select list - but adding them so flake8 works on our project even without hacking doesn't seem to cause any problems. Also The [flake8] section's "select" option in tox.ini doesn't seem to run all checks when presented with the space-comma seperated list. I had to pull out the bare except check (H201), because our hacking fix for the "H201 # noqa" hasn't been released to pypi yet (maybe hacking version 0.9.0?). As far as I know the Swift core development team is fully onboard with pep8, and the flake8 checks are mostly like "unused import" stuff - so I *think* this change is more about making the tool test what we want it too and not changing or adding any new requirements or expectations. Change-Id: Ia911c63745100cce182d5c5eb67b77e31c1e9b18 --- test-requirements.txt | 2 +- tox.ini | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test-requirements.txt b/test-requirements.txt index 7036e8d192..0e3414b8c8 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,5 +1,5 @@ # Hacking already pins down pep8, pyflakes and flake8 -hacking>=0.5.6,<0.6 +hacking>=0.8.0,<0.9 coverage nose nosexcover diff --git a/tox.ini b/tox.ini index 2c3cb4f80f..83544b5427 100644 --- a/tox.ini +++ b/tox.ini @@ -42,10 +42,10 @@ commands = {posargs} # it's not a bug that we aren't using all of hacking # H102 -> apache2 license exists # H103 -> license is apache -# H201 -> no bare excepts +# H201 -> no bare excepts # add when hacking supports noqa # H501 -> don't use locals() for str formatting # H903 -> \n not \r\n ignore = H -select = H102, H103, H201, H501, H903 +select = F,E,W,H102,H103,H501,H903 exclude = .venv,.tox,dist,doc,*egg show-source = True