From 662ef280836178bfd1030cffbf686db14882a6f8 Mon Sep 17 00:00:00 2001 From: Alistair Coles Date: Wed, 30 Nov 2022 10:55:17 +0000 Subject: [PATCH] trivial: fix flakey account/test_auditor.py assertion The test assertion assumes the test environment has exactly one policy, but the test setup uses whatever number of policies are currently in POLICIES. This can cause the test to fail in environments where more than one policy is configured. Fix the assertion to also use the actual number of policies. Change-Id: I8fecc583f211913144663c85ab27ad448b5600f8 --- test/unit/account/test_auditor.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/unit/account/test_auditor.py b/test/unit/account/test_auditor.py index 37410af736..d01b2e3677 100644 --- a/test/unit/account/test_auditor.py +++ b/test/unit/account/test_auditor.py @@ -126,8 +126,9 @@ class TestAuditorRealBroker(unittest.TestCase): error_message = error_lines[0] self.assertIn(broker.db_file, error_message) self.assertIn( - 'The total container_count for the account a (3) does not match ' - 'the sum of container_count across policies (2)', error_message) + 'The total container_count for the account a (%d) does not match ' + 'the sum of container_count across policies (%d)' + % (num_containers, num_containers - 1), error_message) self.assertEqual(test_auditor.logger.get_increment_counts(), {'failures': 1})