openstack/swift
Code Issues Proposed changes

tests: Use mock.patch more

Browse Source 
Change-Id: I68974338f8e0284ed77960048a83f72855b93348
This commit is contained in:
Tim Burke 2024-04-30 14:14:30 -07:00
parent b4dddb7406
commit 761d919677
1 changed files with 11 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/unit/common/test_utils.py
View File

@ -904,26 +904,18 @@ class TestUtils(unittest.TestCase):
self.assertEqual(options['extra_args'], ['plugin_name'])
def test_parse_options_errors(self):
orig_stdout = sys.stdout
orig_stderr = sys.stderr
stdo = StringIO()
stde = StringIO()
utils.sys.stdout = stdo
utils.sys.stderr = stde
self.assertRaises(SystemExit, utils.parse_options, once=True,
test_args=[])
self.assertTrue('missing config' in stdo.getvalue())
with mock.patch.object(utils.sys, 'stdout', StringIO()) as stdo:
self.assertRaises(SystemExit, utils.parse_options, once=True,
test_args=[])
self.assertTrue('missing config' in stdo.getvalue())
# verify conf file must exist, context manager will delete temp file
with NamedTemporaryFile() as f:
conf_file = f.name
self.assertRaises(SystemExit, utils.parse_options, once=True,
test_args=[conf_file])
self.assertTrue('unable to locate' in stdo.getvalue())
# reset stdio
utils.sys.stdout = orig_stdout
utils.sys.stderr = orig_stderr
# verify conf file must exist -- context manager will delete
# temp file
with NamedTemporaryFile() as f:
conf_file = f.name
self.assertRaises(SystemExit, utils.parse_options, once=True,
test_args=[conf_file])
self.assertTrue('unable to locate' in stdo.getvalue())
@with_tempdir
def test_dump_recon_cache(self, testdir_base):