openstack/swift
Code Issues Proposed changes

Let swift-object-info skip etag verification

Browse Source 
Now swift-object-info has a "-n" option that will cause the etag
verification to be skipped; on large objects, the etag verification
takes the vast majority of the runtime, and sometimes you just want to
know which account owns the 5 GB monstrosity without waiting around while
its checksum is verified.

Change-Id: Id284570633eb7b98046cdb948d7c37a152de1195
This commit is contained in:
Samuel Merritt 2014-01-16 12:50:48 -08:00
parent d68fbfc9ed
commit 92fc917b4b
1 changed files with 42 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
bin/swift-object-info
View File

@ -14,23 +14,22 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
import os
import sys import sys
from datetime import datetime from datetime import datetime
from hashlib import md5 from hashlib import md5
from optparse import OptionParser
from swift.common.ring import Ring from swift.common.ring import Ring
from swift.obj.diskfile import read_metadata from swift.obj.diskfile import read_metadata
from swift.common.utils import hash_path from swift.common.utils import hash_path
if __name__ == '__main__':
if len(sys.argv) <= 1: def print_object_info(datafile, check_etag=True):
print "Usage: %s OBJECT_FILE" % sys.argv[0]
sys.exit(1)
try: try:
ring = Ring('/etc/swift/', ring_name='object') ring = Ring('/etc/swift/', ring_name='object')
except Exception: except Exception:
ring = None ring = None
datafile = sys.argv[1]
fp = open(datafile, 'rb') fp = open(datafile, 'rb')
metadata = read_metadata(fp) metadata = read_metadata(fp)
path = metadata.pop('name', '') path = metadata.pop('name', '')
@ -63,6 +62,9 @@ if __name__ == '__main__':
print 'Timestamp: %s (%s)' % (datetime.fromtimestamp(float(ts)), ts) print 'Timestamp: %s (%s)' % (datetime.fromtimestamp(float(ts)), ts)
else: else:
print 'Timestamp: Not found in metadata' print 'Timestamp: Not found in metadata'
file_len = None
if check_etag:
h = md5() h = md5()
file_len = 0 file_len = 0
while True: while True:
@ -79,6 +81,10 @@ if __name__ == '__main__':
print "Etag: %s doesn't match file hash of %s!" % (etag, h) print "Etag: %s doesn't match file hash of %s!" % (etag, h)
else: else:
print 'ETag: Not found in metadata' print 'ETag: Not found in metadata'
else:
print 'ETag: %s (not checked)' % etag
file_len = os.fstat(fp.fileno()).st_size
if length: if length:
if file_len == int(length): if file_len == int(length):
print 'Content-Length: %s (valid)' % length print 'Content-Length: %s (valid)' % length
@ -92,3 +98,20 @@ if __name__ == '__main__':
print 'note: /srv/node is used as default value of `devices`, the real '\ print 'note: /srv/node is used as default value of `devices`, the real '\
'value is set in object-server.conf on each storage node.' 'value is set in object-server.conf on each storage node.'
fp.close() fp.close()
if __name__ == '__main__':
parser = OptionParser()
parser.set_defaults(check_etag=True)
parser.add_option(
'-n', '--no-check-etag',
action="store_false", dest="check_etag",
help="Don't verify file contents against stored etag")
options, args = parser.parse_args()
if len(args) < 1:
print "Usage: %s [-n] OBJECT_FILE" % sys.argv[0]
sys.exit(1)
print_object_info(args[0], check_etag=options.check_etag)