From af15ad53fb7818cdf14c92523fd6799bfabc12ec Mon Sep 17 00:00:00 2001 From: Tim Burke Date: Thu, 14 Mar 2024 20:25:36 -0700 Subject: [PATCH] tests: Update CORS geckodriver Change-Id: I5ab762dfe0f85e346c4868ec4540884ba5f0a7f4 --- test/cors/main.py | 8 ++++++-- tools/playbooks/cors/install_selenium.yaml | 4 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/test/cors/main.py b/test/cors/main.py index 5da06ae681..063f967247 100755 --- a/test/cors/main.py +++ b/test/cors/main.py @@ -194,8 +194,12 @@ def run(args, url): try: browser = driver(**kwargs) except Exception as e: - if not ('needs to be in PATH' in str(e) or - 'SafariDriver was not found' in str(e)): + if not any(x in str(e) for x in ( + 'needs to be in PATH', + 'SafariDriver was not found', + 'OSError: [Errno 8] Exec format error', + 'safaridriver not available for download', + )): traceback.print_exc() results.append(('SKIP', browser_name, str(e).strip())) continue diff --git a/tools/playbooks/cors/install_selenium.yaml b/tools/playbooks/cors/install_selenium.yaml index 682c36a875..b7d08c57f7 100644 --- a/tools/playbooks/cors/install_selenium.yaml +++ b/tools/playbooks/cors/install_selenium.yaml @@ -15,13 +15,15 @@ state: present - name: fetch firefox driver get_url: - url: https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodriver-v0.26.0-linux64.tar.gz + url: https://github.com/mozilla/geckodriver/releases/download/v0.34.0/geckodriver-v0.34.0-linux64.tar.gz dest: /tmp/geckodriver.tar.gz - name: unpack firefox driver unarchive: src: /tmp/geckodriver.tar.gz dest: /usr/local/bin remote_src: true + - name: check selenium version + command: pip show selenium - name: check firefox version command: firefox --version #- name: install chromium