openstack/swift
Code Issues Proposed changes

Removed default value for log_statsd_host

Browse Source 
Multiple files and documents showed that log_statsd_host had
a default value, usually localhost.  This was incorrect, instead
setting a value for log_statsd_host enables statsd logging.

Removed any reference of log_statsd_host having a default value.

Also changed descriptions to show setting a value enables logging.

Change-Id: I3ca5c0e8b8e4981de3aa6db0c476072b5a59723d
Closes-Bug: #1542227
This commit is contained in:
gh159m 2016-02-10 10:36:59 -06:00
parent 45a7a15674
commit b5311f63db
11 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/saio/swift/container-reconciler.conf
View File

@ -17,7 +17,7 @@ user = <your-user-name>
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

2
doc/saio/swift/object-expirer.conf
View File

@ -17,7 +17,7 @@ log_level = INFO
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

20
doc/source/deployment_guide.rst
View File

@ -478,7 +478,7 @@ log_custom_handlers None Comma-separated list of functions t
to setup custom log handlers. to setup custom log handlers.
log_udp_host Override log_address log_udp_host Override log_address
log_udp_port 514 UDP log port log_udp_port 514 UDP log port
log_statsd_host localhost StatsD logging; IPv4/IPv6 log_statsd_host None Enables StatsD logging; IPv4/IPv6
address or a hostname. If a address or a hostname. If a
hostname resolves to an IPv4 and IPv6 hostname resolves to an IPv4 and IPv6
address, the IPv4 address will be address, the IPv4 address will be
@ -794,7 +794,11 @@ log_custom_handlers None Comma-separated list of functions t
to setup custom log handlers. to setup custom log handlers.
log_udp_host Override log_address log_udp_host Override log_address
log_udp_port 514 UDP log port log_udp_port 514 UDP log port
log_statsd_host localhost StatsD logging log_statsd_host None Enables StatsD logging; IPv4/IPv6
address or a hostname. If a
hostname resolves to an IPv4 and IPv6
address, the IPv4 address will be
used.
log_statsd_port 8125 log_statsd_port 8125
log_statsd_default_sample_rate 1.0 log_statsd_default_sample_rate 1.0
log_statsd_sample_rate_factor 1.0 log_statsd_sample_rate_factor 1.0
@ -1005,7 +1009,11 @@ log_custom_handlers None Comma-separated list of functions t
to setup custom log handlers. to setup custom log handlers.
log_udp_host Override log_address log_udp_host Override log_address
log_udp_port 514 UDP log port log_udp_port 514 UDP log port
log_statsd_host localhost StatsD logging log_statsd_host None Enables StatsD logging; IPv4/IPv6
address or a hostname. If a
hostname resolves to an IPv4 and IPv6
address, the IPv4 address will be
used.
log_statsd_port 8125 log_statsd_port 8125
log_statsd_default_sample_rate 1.0 log_statsd_default_sample_rate 1.0
log_statsd_sample_rate_factor 1.0 log_statsd_sample_rate_factor 1.0
@ -1233,7 +1241,11 @@ log_custom_handlers None Comma separated
handlers. handlers.
log_udp_host Override log_address log_udp_host Override log_address
log_udp_port 514 UDP log port log_udp_port 514 UDP log port
log_statsd_host localhost StatsD logging log_statsd_host None Enables StatsD logging; IPv4/IPv6
address or a hostname. If a
hostname resolves to an IPv4 and IPv6
address, the IPv4 address will be
used.
log_statsd_port 8125 log_statsd_port 8125
log_statsd_default_sample_rate 1.0 log_statsd_default_sample_rate 1.0
log_statsd_sample_rate_factor 1.0 log_statsd_sample_rate_factor 1.0

2
etc/account-server.conf-sample
View File

@ -35,7 +35,7 @@ bind_port = 6002
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

2
etc/container-reconciler.conf-sample
View File

@ -17,7 +17,7 @@
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

2
etc/container-server.conf-sample
View File

@ -41,7 +41,7 @@ bind_port = 6001
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

2
etc/internal-client.conf-sample
View File

@ -17,7 +17,7 @@
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

4
etc/object-expirer.conf-sample
View File

@ -20,7 +20,7 @@
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0
@ -80,7 +80,7 @@ use = egg:swift#proxy_logging
# access_log_udp_port = 514 # access_log_udp_port = 514
# #
# You can use log_statsd_* from [DEFAULT] or override them here: # You can use log_statsd_* from [DEFAULT] or override them here:
# access_log_statsd_host = localhost # access_log_statsd_host =
# access_log_statsd_port = 8125 # access_log_statsd_port = 8125
# access_log_statsd_default_sample_rate = 1.0 # access_log_statsd_default_sample_rate = 1.0
# access_log_statsd_sample_rate_factor = 1.0 # access_log_statsd_sample_rate_factor = 1.0

2
etc/object-server.conf-sample
View File

@ -44,7 +44,7 @@ bind_port = 6000
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0

4
etc/proxy-server.conf-sample
View File

@ -63,7 +63,7 @@ bind_port = 8080
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0
@ -569,7 +569,7 @@ use = egg:swift#proxy_logging
# access_log_udp_port = 514 # access_log_udp_port = 514
# #
# You can use log_statsd_* from [DEFAULT] or override them here: # You can use log_statsd_* from [DEFAULT] or override them here:
# access_log_statsd_host = localhost # access_log_statsd_host =
# access_log_statsd_port = 8125 # access_log_statsd_port = 8125
# access_log_statsd_default_sample_rate = 1.0 # access_log_statsd_default_sample_rate = 1.0
# access_log_statsd_sample_rate_factor = 1.0 # access_log_statsd_sample_rate_factor = 1.0

2
swift/container/sync.py
View File

@ -65,7 +65,7 @@ ic_conf_body = """
# log_udp_port = 514 # log_udp_port = 514
# #
# You can enable StatsD logging here: # You can enable StatsD logging here:
# log_statsd_host = localhost # log_statsd_host =
# log_statsd_port = 8125 # log_statsd_port = 8125
# log_statsd_default_sample_rate = 1.0 # log_statsd_default_sample_rate = 1.0
# log_statsd_sample_rate_factor = 1.0 # log_statsd_sample_rate_factor = 1.0