openstack/swift
Code Issues Proposed changes

tests: bust md5 of object not footers

Browse Source 
The test test_PUT_ec_fragment_quorum_archive_etag_mismatch
busts the md5 in server.py, so it ends damaging the md5 of
footers instead of the fragment archive. It appears that the
intention of the test was to check the integrity verification
for fragment archive, so change the test to bust diskfile.py
instead.

Change-Id: I54a203bb637d5f5814e8df2b4297758b0b72adac
This commit is contained in:
Pete Zaitcev 2019-05-03 14:51:47 -05:00 committed by Tim Burke
parent ff91df2302
commit bb5fa0ea2e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/unit/proxy/test_server.py
View File

@ -6688,8 +6688,11 @@ class BaseTestECObjectController(BaseTestObjectController):
commit_confirmation = \
'swift.proxy.controllers.obj.MIMEPutter.send_commit_confirmation'
diskfile_md5 = 'swift.obj.diskfile.md5'
mem_diskfile_md5 = 'swift.obj.mem_diskfile.hashlib.md5'
with mock.patch('swift.obj.server.md5', busted_md5_constructor), \
with mock.patch(diskfile_md5, busted_md5_constructor), \
mock.patch(mem_diskfile_md5, busted_md5_constructor), \
mock.patch(commit_confirmation, mock_committer):
fd = sock.makefile('rwb')
fd.write(('PUT /v1/a/ec-con/quorum HTTP/1.1\r\n'