openstack/swift
Code Issues Proposed changes

Use extract_swift_bytes in override_bytes_from_content_type

Browse Source 
About half the logic was the same, and it seems better to just implement
that once.

Change-Id: I350da34ef7a3cd0cb74f585f4691992ae64c7eab
This commit is contained in:
Tim Burke 2016-07-25 15:02:03 -07:00
parent 68cb2f1e74
commit bf17d96800
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
swift/common/utils.py
View File

@ -3429,17 +3429,14 @@ def override_bytes_from_content_type(listing_dict, logger=None):
Takes a dict from a container listing and overrides the content_type, Takes a dict from a container listing and overrides the content_type,
bytes fields if swift_bytes is set. bytes fields if swift_bytes is set.
""" """
content_type, params = parse_content_type(listing_dict['content_type']) listing_dict['content_type'], swift_bytes = extract_swift_bytes(
for key, value in params: listing_dict['content_type'])
if key == 'swift_bytes': if swift_bytes is not None:
try: try:
listing_dict['bytes'] = int(value) listing_dict['bytes'] = int(swift_bytes)
except ValueError: except ValueError:
if logger: if logger:
logger.exception("Invalid swift_bytes") logger.exception("Invalid swift_bytes")
else:
content_type += ';%s=%s' % (key, value)
listing_dict['content_type'] = content_type
def clean_content_type(value): def clean_content_type(value):