From c46b88ab742761c8918013fa9cc40a169e015474 Mon Sep 17 00:00:00 2001 From: zhufl Date: Fri, 28 Jun 2019 16:54:27 +0800 Subject: [PATCH] Fix invalid assert states "self.assertTrue(policies[1].is_deprecated, True)" and "self.assertTrue(crashy_calls[0], 1)" are not correct, this is to fix them. Change-Id: I7b07f0833d675d2939c910f679b54da2b8cda482 --- test/unit/common/test_storage_policy.py | 2 +- test/unit/common/test_utils.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unit/common/test_storage_policy.py b/test/unit/common/test_storage_policy.py index ba30b568a2..ea172e368b 100644 --- a/test/unit/common/test_storage_policy.py +++ b/test/unit/common/test_storage_policy.py @@ -762,7 +762,7 @@ class TestStoragePolicies(unittest.TestCase): policies = parse_storage_policies(good_conf) self.assertEqual(policies.default, policies[0]) - self.assertTrue(policies[1].is_deprecated, True) + self.assertTrue(policies[1].is_deprecated) def test_parse_storage_policies(self): # ValueError when deprecating policy 0 diff --git a/test/unit/common/test_utils.py b/test/unit/common/test_utils.py index 9dbbadcf89..c8393b96f5 100644 --- a/test/unit/common/test_utils.py +++ b/test/unit/common/test_utils.py @@ -1414,7 +1414,7 @@ class TestUtils(unittest.TestCase): # pdb is basically impossible. Sorry about that. utils.capture_stdio(logger) logger.info("I like ham") - self.assertTrue(crashy_calls[0], 1) + self.assertGreater(crashy_calls[0], 1) def test_parse_options(self): # Get a file that is definitely on disk