log return value before arguments when rsync error

The arguments of rsync command seems too long. If some errors occur, it
is hard to debug. Moving return value of rsync command first could help
people at least know reason of rsync error by manuals.

fixes bug #903406

Change-Id: I1cac7bbca74824a6d47e6ceb9f654d4046fcbb9e
This commit is contained in:
Kun Huang 2013-07-15 15:43:56 +08:00 committed by Gerrit Code Review
parent 3748b54a1b
commit c7a79991f8

View File

@ -111,7 +111,7 @@ class ObjectReplicator(Daemon):
else:
self.logger.error(result)
if ret_val:
self.logger.error(_('Bad rsync return code: %(args)s -> %(ret)d'),
self.logger.error(_('Bad rsync return code: %(ret)d <- %(args)s'),
{'args': str(args), 'ret': ret_val})
elif results:
self.logger.info(