openstack/swift
Code Issues Proposed changes

Remove unneeded setting of SO_REUSEADDR.

Browse Source 
This has been in eventlet.listen() since version 0.15.

Change-Id: Ib77b28231a2180f1ea082f356c4687c39681a6f7
This commit is contained in:
Samuel Merritt 2016-05-04 16:48:28 -07:00
parent 2bf5eb775f
commit deaef2f9d6
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
swift/common/wsgi.py
View File

@ -199,7 +199,6 @@ def get_socket(conf):
raise Exception(_('Could not bind to %s:%s ' raise Exception(_('Could not bind to %s:%s '
'after trying for %s seconds') % ( 'after trying for %s seconds') % (
bind_addr[0], bind_addr[1], bind_timeout)) bind_addr[0], bind_addr[1], bind_timeout))
sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
# in my experience, sockets can hang around forever without keepalive # in my experience, sockets can hang around forever without keepalive
sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1) sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)

1
test/unit/common/test_wsgi.py
View File

@ -276,7 +276,6 @@ class TestWSGI(unittest.TestCase):
self.assertTrue(isinstance(sock, MockSocket)) self.assertTrue(isinstance(sock, MockSocket))
expected_socket_opts = { expected_socket_opts = {
socket.SOL_SOCKET: { socket.SOL_SOCKET: {
socket.SO_REUSEADDR: 1,
socket.SO_KEEPALIVE: 1, socket.SO_KEEPALIVE: 1,
}, },
socket.IPPROTO_TCP: { socket.IPPROTO_TCP: {