From e264ca88e2ffe68e9a8869b4190a5e1c337a8d90 Mon Sep 17 00:00:00 2001 From: Clay Gerrard Date: Thu, 19 Mar 2020 19:15:03 -0500 Subject: [PATCH] Recommend better rsync.conf settings Swift doesn't recommend any rsync hostname allow/deny rules for inside your cluster network and I've never heard of anyone using it. The reverse lookup on connect (even those denied for max connections) can be overwhelming during a rebalance. Since rsync allows explicit control of the behavior after 3.1 we should suggest operators use it, It's also nominally more efficient in all cases. Possible drawback is maybe in the future a Swift operator has good reason to use host allow/deny rules and don't realize the rsync settings we recommend are mutually exclusive with their customizations. Change-Id: I2fdffdf1cc0a77f994c1d7894d5a1c8e5d951755 --- etc/rsyncd.conf-sample | 3 +++ 1 file changed, 3 insertions(+) diff --git a/etc/rsyncd.conf-sample b/etc/rsyncd.conf-sample index cdf666bde9..3b6a77191c 100644 --- a/etc/rsyncd.conf-sample +++ b/etc/rsyncd.conf-sample @@ -2,6 +2,9 @@ uid = swift gid = swift log file = /var/log/rsyncd.log pid file = /var/run/rsyncd.pid +# since rsync default for reverse lookup is true, you have to set it to false +# here globally or after a few 100 nodes your dns team will fuss at you +reverse lookup = false [account] max connections = 2