openstack/swift
Code Issues Proposed changes

wsgi: Start workers in parallel, rather than serially

Browse Source 
A single worker can take a second or two to start up, which really adds
up when you've got, say, 48 workers.

Change-Id: Id9e8b7e670a67233ac8b79da0b7b8387e302ac02
Related-Change: I83cdaa2cbd394cbd49609c65bf9c5ed026c55417
This commit is contained in:
Tim Burke 2022-10-27 16:23:51 -07:00
parent 052abed755
commit f08b8e0af2
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
swift/common/wsgi.py
View File

@ -970,7 +970,7 @@ class ServersPerPortStrategy(StrategyBase):
Called when a new worker is started. Called when a new worker is started.
:param socket sock: The listen socket for the worker just started. :param socket sock: The listen socket for the worker just started.
:param server_idx: The socket's server_idx as yielded by :param tuple data: The socket's (port, server_idx) as yielded by
:py:meth:`new_worker_socks`. :py:meth:`new_worker_socks`.
:param int pid: The new worker process' PID :param int pid: The new worker process' PID
""" """
@ -1090,6 +1090,7 @@ def run_wsgi(conf_path, app_section, *args, **kwargs):
signal.signal(signal.SIGUSR1, stop_with_signal) signal.signal(signal.SIGUSR1, stop_with_signal)
while running_context[0]: while running_context[0]:
new_workers = {} # pid -> status pipe
for sock, sock_info in strategy.new_worker_socks(): for sock, sock_info in strategy.new_worker_socks():
read_fd, write_fd = os.pipe() read_fd, write_fd = os.pipe()
pid = os.fork() pid = os.fork()
@ -1114,16 +1115,16 @@ def run_wsgi(conf_path, app_section, *args, **kwargs):
return 0 return 0
else: else:
os.close(write_fd) os.close(write_fd)
new_workers[pid] = read_fd
strategy.register_worker_start(sock, sock_info, pid)
for pid, read_fd in new_workers.items():
worker_status = os.read(read_fd, 30) worker_status = os.read(read_fd, 30)
os.close(read_fd) os.close(read_fd)
# TODO: delay this status checking until after we've tried if worker_status != b'ready':
# to start all workers. But, we currently use the register
# event to know when we've got enough workers :-/
if worker_status == b'ready':
strategy.register_worker_start(sock, sock_info, pid)
else:
raise Exception( raise Exception(
'worker did not start normally: %r' % worker_status) 'worker %d did not start normally: %r' %
(pid, worker_status))
# TODO: signal_ready() as soon as we have at least one new worker for # TODO: signal_ready() as soon as we have at least one new worker for
# each port, instead of waiting for all of them # each port, instead of waiting for all of them