From ee693265fe01e9ca3b3151812d5f14db0109311b Mon Sep 17 00:00:00 2001 From: Clay Gerrard Date: Wed, 26 Aug 2020 12:24:46 -0500 Subject: [PATCH] swift-init: Don't expose misleading commands The kill_child_pids command does NOT need to be an @command to be available in probe tests. I don't think it's helpful to operators, since restarting all children is best handled by existing reload/seamless-reload commands. But mainly the seamless option is misleading since it very much results in a NOT seamless reload (all workers close sockets immediately, and nothing can accept new connections until existing connections finish and the parent spawns replacement workers - i.e. it's just like graceful) Change-Id: Ic4b274da7dcf9b166513d9c138f4b0370b01eeb0 --- swift/common/manager.py | 1 - 1 file changed, 1 deletion(-) diff --git a/swift/common/manager.py b/swift/common/manager.py index d5731f53bf..4579da1148 100644 --- a/swift/common/manager.py +++ b/swift/common/manager.py @@ -381,7 +381,6 @@ class Manager(object): status += 1 return status - @command def kill_child_pids(self, **kwargs): """kill child pids, optionally servicing accepted connections""" status = 0