0996433fe5
Some tooling out there, like Ansible, will always call to see if
object-lock is enabled on a bucket/container. This fails as Swift doesn't
understand the object-lock or the get object lock api[0].
When you use the get-object-lock-configuration to a bucket in s3 that
doesn't have it applied it returns a specific 404:
GET /?object-lock HTTP/1.1" 404 None
...
<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>ObjectLockConfigurationNotFoundError</Code>
<Message>Object Lock configuration does not exist for this bucket</Message>
<BucketName>bucket_name</BucketName>
<RequestId>83VQBYP0SENV3VP4</RequestId>
</Error>'
This patch doesn't add support for get_object lock, instead it always
returns a similar 404 as supplied by s3, so clients know it's not
enabled.
Also add a object-lock PUT 501 response.
[0] https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObjectLockConfiguration.html
Change-Id: Icff8cf57474dfad975a4f45bf2d500c2682c1129
52 lines
1.8 KiB
Python
52 lines
1.8 KiB
Python
# Copyright (c) 2010-2023 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import botocore
|
|
|
|
from test.s3api import BaseS3TestCase
|
|
|
|
|
|
class TestObjectLockConfiguration(BaseS3TestCase):
|
|
|
|
maxDiff = None
|
|
|
|
def setUp(self):
|
|
self.client = self.get_s3_client(1)
|
|
self.bucket_name = self.create_name('objlock')
|
|
resp = self.client.create_bucket(Bucket=self.bucket_name)
|
|
self.assertEqual(200, resp['ResponseMetadata']['HTTPStatusCode'])
|
|
|
|
def tearDown(self):
|
|
self.clear_bucket(self.client, self.bucket_name)
|
|
super(TestObjectLockConfiguration, self).tearDown()
|
|
|
|
def test_get_object_lock_configuration(self):
|
|
with self.assertRaises(botocore.exceptions.ClientError) as ce:
|
|
self.client.get_object_lock_configuration(
|
|
Bucket=self.bucket_name)
|
|
|
|
self.assertEqual(
|
|
ce.exception.response['ResponseMetadata']['HTTPStatusCode'],
|
|
404)
|
|
self.assertEqual(
|
|
ce.exception.response['Error']['Code'],
|
|
'ObjectLockConfigurationNotFoundError')
|
|
|
|
self.assertEqual(
|
|
str(ce.exception),
|
|
'An error occurred (ObjectLockConfigurationNotFoundError) when '
|
|
'calling the GetObjectLockConfiguration operation: Object Lock '
|
|
'configuration does not exist for this bucket')
|