597072cc95
With the container quota middleware on, if you made a request similar to the following one you'd get a 500 response. curl -i -X PUT -H 'X-Auth-Token: token' http://127.0.0.1:8080/v1/AUTH_testhttp://something/something_else (Note the double url.) This was due to a mismatch in how split_path() was called in the middleware and in the get_container_info(). This change fixes that mismatch and the bug. Change-Id: Ie42ab585b942b7201e13b02a0c706532952aac60
108 lines
4.9 KiB
Python
108 lines
4.9 KiB
Python
# Copyright (c) 2010-2012 OpenStack, LLC.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""
|
|
The ``container_quotas`` middleware implements simple quotas that can be
|
|
imposed on swift containers by a user with the ability to set container
|
|
metadata, most likely the account administrator. This can be useful for
|
|
limiting the scope of containers that are delegated to non-admin users, exposed
|
|
to ``formpost`` uploads, or just as a self-imposed sanity check.
|
|
|
|
Any object PUT operations that exceed these quotas return a 413 response
|
|
(request entity too large) with a descriptive body.
|
|
|
|
Quotas are subject to several limitations: eventual consistency, the timeliness
|
|
of the cached container_info (60 second ttl by default), and it's unable to
|
|
reject chunked transfer uploads that exceed the quota (though once the quota
|
|
is exceeded, new chunked transfers will be refused).
|
|
|
|
Quotas are set by adding meta values to the container, and are validated when
|
|
set:
|
|
|
|
+---------------------------------------------+-------------------------------+
|
|
|Metadata | Use |
|
|
+=============================================+===============================+
|
|
| X-Container-Meta-Quota-Bytes | Maximum size of the |
|
|
| | container, in bytes. |
|
|
+---------------------------------------------+-------------------------------+
|
|
| X-Container-Meta-Quota-Count | Maximum object count of the |
|
|
| | container. |
|
|
+---------------------------------------------+-------------------------------+
|
|
"""
|
|
|
|
from swift.common.http import is_success
|
|
from swift.proxy.controllers.base import get_container_info
|
|
from swift.common.swob import Response, HTTPBadRequest, wsgify
|
|
|
|
|
|
class ContainerQuotaMiddleware(object):
|
|
def __init__(self, app, *args, **kwargs):
|
|
self.app = app
|
|
|
|
def bad_response(self, req, container_info):
|
|
# 401 if the user couldn't have PUT this object in the first place.
|
|
# This prevents leaking the container's existence to unauthed users.
|
|
if 'swift.authorize' in req.environ:
|
|
req.acl = container_info['write_acl']
|
|
aresp = req.environ['swift.authorize'](req)
|
|
if aresp:
|
|
return aresp
|
|
return Response(status=413, body='Upload exceeds quota.')
|
|
|
|
@wsgify
|
|
def __call__(self, req):
|
|
try:
|
|
(version, account, container, obj) = req.split_path(3, 4, True)
|
|
except ValueError:
|
|
return self.app
|
|
|
|
# verify new quota headers are properly formatted
|
|
if not obj and req.method in ('PUT', 'POST'):
|
|
val = req.headers.get('X-Container-Meta-Quota-Bytes')
|
|
if val and not val.isdigit():
|
|
return HTTPBadRequest(body='Invalid bytes quota.')
|
|
val = req.headers.get('X-Container-Meta-Quota-Count')
|
|
if val and not val.isdigit():
|
|
return HTTPBadRequest(body='Invalid count quota.')
|
|
|
|
# check user uploads against quotas
|
|
elif obj and req.method == 'PUT':
|
|
container_info = get_container_info(
|
|
req.environ, self.app, swift_source='CQ')
|
|
if not container_info or not is_success(container_info['status']):
|
|
# this will hopefully 404 later
|
|
return self.app
|
|
if 'quota-bytes' in container_info.get('meta', {}) and \
|
|
'bytes' in container_info and \
|
|
container_info['meta']['quota-bytes'].isdigit():
|
|
new_size = int(container_info['bytes']) + (req.content_length
|
|
or 0)
|
|
if int(container_info['meta']['quota-bytes']) < new_size:
|
|
return self.bad_response(req, container_info)
|
|
if 'quota-count' in container_info.get('meta', {}) and \
|
|
'object_count' in container_info and \
|
|
container_info['meta']['quota-count'].isdigit():
|
|
new_count = int(container_info['object_count']) + 1
|
|
if int(container_info['meta']['quota-count']) < new_count:
|
|
return self.bad_response(req, container_info)
|
|
|
|
return self.app
|
|
|
|
|
|
def filter_factory(global_conf, **local_conf):
|
|
def container_quota_filter(app):
|
|
return ContainerQuotaMiddleware(app)
|
|
return container_quota_filter
|