From 0d2fb5e71d4876c827fee4ff507f1957a195a356 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= <radoslaw.piliszek@gmail.com>
Date: Sat, 10 Sep 2022 08:53:45 +0000
Subject: [PATCH] [ansible-lint] Restore sanity

1.
ansible-lint verbosity is only really required for debugging which
is best done locally, on-demand.

2.
There are almost a hundred violations of fqcn-builtins which
makes it hard to navigate ansible-lint warnings.

3.
command-instead-of-shell and 106 are no longer violated.

There are only 6 warnings now.

Change-Id: I98fb0e587373f85d78a58e84fa8051cbc18f2d8b
---
 .ansible-lint | 4 +---
 tox.ini       | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/.ansible-lint b/.ansible-lint
index 78e11f1..597864b 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -1,9 +1,7 @@
 skip_list:
-  - '106'  # Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern'
+  - fqcn-builtins  # Use FQCN for builtin actions.
 
 warn_list:
   - no-changed-when
-  - command-instead-of-shell  # Use shell only when shell functionality is required
   - experimental  # all rules tagged as experimental
-  - fqcn-builtins  # Use FQCN for builtin actions.
   - jinja[spacing] # Jinja2 spacing could be improved
diff --git a/tox.ini b/tox.ini
index c6c69b7..3f0203d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -72,7 +72,7 @@ commands =
 setenv = ANSIBLE_LIBRARY = {toxinidir}/ansible/action_plugins/
 # Exclude roles downloaded from Galaxy (in the form 'author.role') from
 # linting.
-commands = bash -c "ansible-lint -vvv \
+commands = bash -c "ansible-lint \
                     {toxinidir}/ansible/deploy.yml \
                     {toxinidir}/ansible/teardown.yml"