openstack/trove
Code Issues Proposed changes

Remove global default_password_length

Browse Source 
This option was deprecated multiple cycles ago[1] in favor of
the datastore specific options.

[1] f4cbaf6ccd3c6de14837fcf9532e44de1265bdf6

Change-Id: I1b40fb528d5df52f132a1d8cf027a42d8b65d544
This commit is contained in:
Takashi Kajinami 2024-01-13 00:59:54 +09:00
parent f9fa6a674e
commit 235bd9acd7
2 changed files with 17 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
releasenotes/notes/remove-global-default_password_length-a30b75abb0c5091f.yaml Normal file
View File

@ -0,0 +1,5 @@
---
upgrade:
- |
The ``[DEFAULT] default_password_length`` option has been removed. Use
the datastore specific ``default_password_length`` option instead.

48
trove/common/cfg.py
View File

@ -656,9 +656,7 @@ mysql_opts = [
deprecated_reason='Will be replaced by a configuration group ' deprecated_reason='Will be replaced by a configuration group '
'option: long_query_time'), 'option: long_query_time'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.'),
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
cfg.StrOpt( cfg.StrOpt(
'docker_image', default='mysql', 'docker_image', default='mysql',
help='Database docker image.' help='Database docker image.'
@ -739,9 +737,7 @@ percona_opts = [
'option: long_query_time'), 'option: long_query_time'),
cfg.IntOpt('default_password_length', cfg.IntOpt('default_password_length',
default='${mysql.default_password_length}', default='${mysql.default_password_length}',
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# Percona XtraDB Cluster # Percona XtraDB Cluster
@ -821,9 +817,7 @@ pxc_opts = [
'option: long_query_time'), 'option: long_query_time'),
cfg.IntOpt('default_password_length', cfg.IntOpt('default_password_length',
default='${mysql.default_password_length}', default='${mysql.default_password_length}',
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
@ -883,9 +877,7 @@ redis_opts = [
cfg.StrOpt('guest_log_exposed_logs', default='', cfg.StrOpt('guest_log_exposed_logs', default='',
help='List of Guest Logs to expose for publishing.'), help='List of Guest Logs to expose for publishing.'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# Cassandra # Cassandra
@ -949,9 +941,7 @@ cassandra_opts = [
help='Class that implements datastore-specific Guest Agent API ' help='Class that implements datastore-specific Guest Agent API '
'logic.'), 'logic.'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.'),
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
cfg.BoolOpt('enable_cluster_instance_backup', cfg.BoolOpt('enable_cluster_instance_backup',
default=False, default=False,
help='Allows backup of single instance in the cluster.'), help='Allows backup of single instance in the cluster.'),
@ -1016,9 +1006,7 @@ couchbase_opts = [
cfg.StrOpt('guest_log_exposed_logs', default='', cfg.StrOpt('guest_log_exposed_logs', default='',
help='List of Guest Logs to expose for publishing.'), help='List of Guest Logs to expose for publishing.'),
cfg.IntOpt('default_password_length', default=24, min=6, max=24, cfg.IntOpt('default_password_length', default=24, min=6, max=24,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# MongoDB # MongoDB
@ -1097,9 +1085,7 @@ mongodb_opts = [
cfg.StrOpt('guest_log_exposed_logs', default='', cfg.StrOpt('guest_log_exposed_logs', default='',
help='List of Guest Logs to expose for publishing.'), help='List of Guest Logs to expose for publishing.'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# PostgreSQL # PostgreSQL
@ -1184,9 +1170,7 @@ postgresql_opts = [
deprecated_reason='Will be replaced by configuration group ' deprecated_reason='Will be replaced by configuration group '
'option: log_min_duration_statement'), 'option: log_min_duration_statement'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# Apache CouchDB # Apache CouchDB
@ -1237,9 +1221,7 @@ couchdb_opts = [
deprecated_name='ignore_dbs', deprecated_name='ignore_dbs',
deprecated_group='DEFAULT'), deprecated_group='DEFAULT'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# Vertica # Vertica
@ -1306,9 +1288,7 @@ vertica_opts = [
cfg.IntOpt('min_ksafety', default=0, cfg.IntOpt('min_ksafety', default=0,
help='Minimum k-safety setting permitted for vertica clusters'), help='Minimum k-safety setting permitted for vertica clusters'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# DB2 # DB2
@ -1351,9 +1331,7 @@ db2_opts = [
cfg.StrOpt('guest_log_exposed_logs', default='', cfg.StrOpt('guest_log_exposed_logs', default='',
help='List of Guest Logs to expose for publishing.'), help='List of Guest Logs to expose for publishing.'),
cfg.IntOpt('default_password_length', default=36, cfg.IntOpt('default_password_length', default=36,
help='Character length of generated passwords.', help='Character length of generated passwords.')
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
] ]
# MariaDB # MariaDB
@ -1437,9 +1415,7 @@ mariadb_opts = [
'logic.'), 'logic.'),
cfg.IntOpt('default_password_length', cfg.IntOpt('default_password_length',
default='${mysql.default_password_length}', default='${mysql.default_password_length}',
help='Character length of generated passwords.', help='Character length of generated passwords.'),
deprecated_name='default_password_length',
deprecated_group='DEFAULT'),
cfg.StrOpt( cfg.StrOpt(
'docker_image', default='mariadb', 'docker_image', default='mariadb',
help='Database docker image.' help='Database docker image.'